Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ssmtp: fix configuration generator to accomodate ssmtp #105706

Merged
merged 1 commit into from Dec 30, 2020
Merged

nixos/ssmtp: fix configuration generator to accomodate ssmtp #105706

merged 1 commit into from Dec 30, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Dec 2, 2020

Motivation for this change

This replaces concatStringsSep "\n" with the proper generator to make sure
that the generated configuration file ends with a trailing \n, which is
required by ssmtp's picky configuration parser to take the last configuration
key into account.

GitHub: closes #105704

This should also be back-ported to release-20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested replacing the module locally
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
nixos/ssmtp: fix configuration generator to accomodate ssmtp
a2c4419 
This replaces `concatStringsSep "\n"` with the proper generator to make sure
that the generated configuration file ends with a trailing `\n`, which is
required by ssmtp's picky configuration parser to take the last configuration
key into account.

GitHub: closes NixOS#105704
minijackson
minijackson approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fricklerhandwerk
fricklerhandwerk approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/305

@pacien pacien added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 28, 2020
@AndersonTorres
Copy link
Member

Now the stable, please.

@AndersonTorres AndersonTorres merged commit b17e9cb into NixOS:master Dec 30, 2020
@pacien pacien mentioned this pull request Dec 30, 2020
Merged
11 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minijackson minijackson minijackson approved these changes

@roosemberth roosemberth roosemberth approved these changes

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssmtp: last configuration line not taken into account
7 participants
@pacien @nixos-discourse @AndersonTorres @minijackson @roosemberth @fricklerhandwerk @erictapen