Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osx-cpu-temp: Init at 1.0 #105938

Merged
merged 1 commit into from Dec 11, 2020
Merged

osx-cpu-temp: Init at 1.0 #105938

merged 1 commit into from Dec 11, 2020

Conversation

virusdave
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 5, 2020
View reviewed changes
pkgs/os-specific/darwin/osx-cpu-temp/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/osx-cpu-temp/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/osx-cpu-temp/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105938 run on x86_64-darwin 1

1 package built:
  • osx-cpu-temp

@virusdave
Copy link
Contributor Author

@SuperSandro2000 PTAL, thanks!

SuperSandro2000
SuperSandro2000 requested changes Dec 7, 2020
View reviewed changes
pkgs/os-specific/darwin/osx-cpu-temp/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/osx-cpu-temp/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Also please squash the commits together.

@virusdave virusdave force-pushed the dnicponski/scratch/add_osx-cpu-temp branch from 6be1766 to 9fbe8cc Compare December 9, 2020 17:18
@virusdave
Copy link
Contributor Author

Also please squash the commits together.

Done, PTAL. Thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105938 run on x86_64-darwin 1

1 package built:
  • osx-cpu-temp

@SuperSandro2000 SuperSandro2000 merged commit f097374 into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@virusdave @SuperSandro2000