Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlclient: init at 4.12.0 #106052

Closed
wants to merge 1 commit into from
Closed

tlclient: init at 4.12.0 #106052

wants to merge 1 commit into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#105399

Things done

Packaged non-free thin linc client for linux x86_64

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NomisIV
Copy link
Contributor

NomisIV commented Dec 8, 2020

I don't know what it's worth, but this has got it working for me. I copied the default.nix to my machine and imported it using pkgs.callPackage, and it just works! Thank you very much!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/436

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 106052 1

1 package built:
  • tlclient

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 10, 2021 •
edited

Result of nixpkgs-review pr 106052 1

1 package built:
  • tlclient

Builds and runs. Didn't test the features since I don't have an account.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106052 run on x86_64-linux 1

1 package built:
  • tlclient

@stale
Copy link

stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@SCOTT-HAMILTON SCOTT-HAMILTON changed the base branch from master to staging November 22, 2021 17:52
@thiagokokada
Copy link
Contributor

Please target master, staging is mostly for mass rebuilds.

And sorry for your PR being lost, after you retarget it to master I will do one final test and can merge this PR if everything is right.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 106052 run on x86_64-linux 1

1 package built:
  • tlclient

@thiagokokada thiagokokada changed the base branch from staging to master November 22, 2021 20:34
@thiagokokada thiagokokada changed the base branch from master to staging November 22, 2021 20:34
@thiagokokada
Copy link
Contributor

Please retarget your PR to master instead of staging.

jonringer
jonringer approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/106052

1 package built:
tlclient

This can go in master though. But everyone else looks good 👍

@SCOTT-HAMILTON SCOTT-HAMILTON requested review from Mic92, zowoq and a team as code owners November 23, 2021 18:01
@SCOTT-HAMILTON SCOTT-HAMILTON changed the base branch from staging to master November 23, 2021 18:02
@Mic92 Mic92 removed their request for review November 24, 2021 07:52
@Noah1989 Noah1989 mentioned this pull request Mar 4, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NomisIV NomisIV NomisIV requested changes

@thiagokokada thiagokokada thiagokokada approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@dasJ dasJ Awaiting requested review from dasJ

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@marsam marsam Awaiting requested review from marsam

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@stigtsp stigtsp Awaiting requested review from stigtsp

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

@zakame zakame Awaiting requested review from zakame

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SCOTT-HAMILTON @NomisIV @nixos-discourse @thiagokokada @SuperSandro2000 @jonringer