Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.daphne: 2.5.0 -> 3.0.1 #107390

Merged
merged 1 commit into from Dec 22, 2020
Merged

python3Packages.daphne: 2.5.0 -> 3.0.1 #107390

merged 1 commit into from Dec 22, 2020

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 22, 2020

Motivation for this change

Update to latest upstream release 3.0.1

Changelog: https://github.com/django/daphne/blob/master/CHANGELOG.txt

Should fix the build issue that came up during update for msgpack.

  ERROR: Could not find a version that satisfies the requirement daphne<4,>=3.0 (from channels)
  ERROR: No matching distribution found for daphne<4,>=3.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Dec 22, 2020

Result of nixpkgs-review pr 107390 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis
6 packages built:
  • python37Packages.channels
  • python37Packages.daphne
  • python38Packages.channels
  • python38Packages.daphne
  • python39Packages.channels
  • python39Packages.daphne

This was referenced Dec 22, 2020
Merged
Merged
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107390 run on x86_64-darwin 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis
6 packages built:
  • python37Packages.channels
  • python37Packages.daphne
  • python38Packages.channels
  • python38Packages.daphne
  • python39Packages.channels
  • python39Packages.daphne

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107390 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis
6 packages built:
  • python37Packages.channels
  • python37Packages.daphne
  • python38Packages.channels
  • python38Packages.daphne
  • python39Packages.channels
  • python39Packages.daphne

@SuperSandro2000 SuperSandro2000 merged commit 5e577a5 into NixOS:master Dec 22, 2020
@fabaff fabaff deleted the daphne branch December 23, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000