Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulauncher: 5.8.1 -> 5.9.0 #107409

Merged
merged 1 commit into from Dec 22, 2020
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for ulauncher is: "A fast application launcher for Linux, written in Python, using GTK"

meta.homepage for ulauncher is: "https://ulauncher.io/"

meta.changelog for ulauncher is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
ulauncher
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A ulauncher https://github.com/r-ryantm/nixpkgs/archive/c6f65b1d9303897d53bfbca5fc9af6bd9f25be60.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0
ls -la /nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • ulauncher

Maintainer pings

cc @aaronjanse @worldofpeace for testing.

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 107409 run on x86_64-linux 1

1 package built:
  • ulauncher

@lovesegfault
Copy link
Member

The package builds fine, but I can't actually run it:

2020-12-22 12:28:51,539 | ERROR | ulauncher: except_hook() | Uncaught exception
Traceback (most recent call last):
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/config.py", line 68, in get_data_path
    return paths[0]
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/bin/..ulauncher-wrapped-wrapped", line 29, in <module>
    main()
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/main.py", line 128, in main
    window = UlauncherWindow.get_instance()
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/utils/decorator/singleton.py", line 19, in wrapper
    instance = fn(*args, **kwargs)
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/ui/windows/UlauncherWindow.py", line 55, in get_instance
    return cls()
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/ui/windows/UlauncherWindow.py", line 63, in __new__
    builder = Builder.new_from_file('UlauncherWindow')
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/ui/windows/Builder.py", line 47, in new_from_file
    ui_filename = get_data_file('ui', '%s.ui' % (builder_file_name,))
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/config.py", line 42, in get_data_file
    return os.path.join(get_data_path(), *path_segments)
  File "/nix/store/vyzs4nm0s9gr81nsifgrm7bvq2fd9fj7-ulauncher-5.9.0/lib/python3.8/site-packages/ulauncher/config.py", line 70, in get_data_path
    raise ProjectPathNotFoundError()
ulauncher.config.ProjectPathNotFoundError

@aaronjanse
Copy link
Member

Related: #85350

Copy link
Member

@aaronjanse aaronjanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package builds fine, but I can't actually run it:

As commented in the above-linked PR, this happens when ulauncher is launched in an ephemeral shell rather than being installed. Since this version bump has the same bug (rather than being a regression), I'm in favor of merging this version bump then figuring out the bug (or at least providing a better error message) in a separate PR

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@lovesegfault lovesegfault merged commit d3a8c46 into NixOS:master Dec 22, 2020
@r-ryantm r-ryantm deleted the auto-update/ulauncher branch December 23, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants