Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] kernel/manual-config: prevent chmod errors when there is no arch specific Makefile #107525

Merged
merged 1 commit into from
Sep 21, 2021
Merged

[staging] kernel/manual-config: prevent chmod errors when there is no arch specific Makefile #107525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkgs/os-specific/linux/kernel/manual-config.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,7 @@ let
find . -type f -name '*.lds' -print0 | xargs -0 -r chmod u-w

# Keep root and arch-specific Makefiles
chmod u-w Makefile
chmod u-w arch/$arch/Makefile*
chmod u-w Makefile arch/"$arch"/Makefile*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change $arch to "$arch"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its quoted in all other places in this file. Even if I somewhat doubt people will start adding architectures with spaces in them, its good to be consistent I guess?


# Keep whole scripts dir
chmod u-w -R scripts
Expand Down