Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.dracula: unstable-2020-12-2 -> unstable-2020-12-28 #107552

Merged
merged 1 commit into from Dec 30, 2020
Merged

tmuxPlugins.dracula: unstable-2020-12-2 -> unstable-2020-12-28 #107552

merged 1 commit into from Dec 30, 2020

Conversation

ethancedwards8
Copy link
Member

Motivation for this change

Update the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ethancedwards8 ethancedwards8 changed the title tmuxPlugins.dracula: unstable-2020-12-2 -> unstable-2020-12-24 tmuxPlugins.dracula: unstable-2020-12-2 -> unstable-2020-12-28 Dec 28, 2020
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107552 1

1 package built:
  • tmuxPlugins.dracula

thiagokokada
thiagokokada approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how exactly to test this, but I build the package and it seems ok so approved.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/312

@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Dec 30, 2020 •
edited

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/312

I'm assuming thats a good thing :)

@thiagokokada
Copy link
Contributor

Yeah, I am trying to give more visibility that your PR is ok and ready to be merged.

@ethancedwards8
Copy link
Member Author

Okay cool thanks

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107552 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.dracula

@SuperSandro2000
Copy link
Member

Yeah, I am trying to give more visibility that your PR is ok and ready to be merged.

You can also write me on IRC or mention me and I'll take a look at it in the coming days.

@SuperSandro2000 SuperSandro2000 merged commit ecf9b8b into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethancedwards8 @thiagokokada @nixos-discourse @SuperSandro2000