Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monsoon: init at 0.6.0 #107640

Merged
merged 1 commit into from Jan 11, 2021
Merged

monsoon: init at 0.6.0 #107640

merged 1 commit into from Jan 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 26, 2020

Motivation for this change

monsoon (https://github.com/RedTeamPentesting/monsoon) is a ast HTTP enumerator.

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107640 run on x86_64-linux 1

1 package built:
  • monsoon

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107640 run on x86_64-darwin 1

1 package failed to build:
  • monsoon
--- FAIL: TestRequestApply (0.00s)
    --- FAIL: TestRequestApply/#00 (0.00s)
panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: bind: operation not permitted [recovered]
    panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: bind: operation not permitted

goroutine 15 [running]:
testing.tRunner.func1.1(0x13bfd80, 0xc0000638e0)
    testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc000158c00)
    testing/testing.go:1075 +0x41a
panic(0x13bfd80, 0xc0000638e0)
    runtime/panic.go:969 +0x1b9
net/http/httptest.newLocalListener(0x1010198, 0x20)
    net/http/httptest/server.go:71 +0x237
net/http/httptest.NewUnstartedServer(...)
    net/http/httptest/server.go:117
net/http/httptest.NewServer(0x14c14c0, 0xc00000fc80, 0x0)
    net/http/httptest/server.go:104 +0x27
github.com/RedTeamPentesting/monsoon/request.TestRequestApply.func2(0xc000158c00)
    github.com/RedTeamPentesting/monsoon/request/request_test.go:808 +0x325
testing.tRunner(0xc000158c00, 0xc00000fc40)
    testing/testing.go:1123 +0xef
created by testing.(*T).Run
    testing/testing.go:1168 +0x2b3
FAIL    github.com/RedTeamPentesting/monsoon/request    0.018s
FAIL

@fabaff
Copy link
Member Author

fabaff commented Dec 29, 2020

Would it be Ok to exclude darwin from the tests?

@SuperSandro2000
Copy link
Member

Would it be Ok to exclude darwin from the tests?

yes.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107640 run on x86_64-darwin 1

1 package built:
  • monsoon

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107640 run on x86_64-darwin 1

1 package built:
  • monsoon

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107640 run on x86_64-linux 1

1 package built:
  • monsoon

@SuperSandro2000 SuperSandro2000 merged commit f337a3f into NixOS:master Jan 11, 2021
@fabaff fabaff deleted the monsoon branch January 15, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants