New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicacy: 2.3.0 -> 2.7.2 #107767
duplicacy: 2.3.0 -> 2.7.2 #107767
Conversation
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
[nix-shell:~/.cache/nixpkgs-review/pr-107767/results/duplicacy/bin]$ ./duplicacy
NAME:
duplicacy - A new generation cloud backup tool based on lock-free deduplication
USAGE:
duplicacy [global options] command [command options] [arguments...]
VERSION:
2.7.2 (unofficial)
COMMANDS:
init Initialize the storage if necessary and the current directory as the repository
backup Save a snapshot of the repository to the storage
[...]
Result of 1 package built:
|
@Dyazz thanks for making your first nixpkgs PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind of small, but
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
duplicacy: 2.3.0 -> 2.7.2
missing :
, and should be lower case
otherwise, LGTM
Result of 1 package built:
|
My bad. I reformatted the commit message. Thanks for the reviews ! |
The title was changed, but the commit is the same. Need to do:
|
Result of 1 package built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
This update brings a lot of news back-ends. You can now use OneDrive as a storage back-end.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)