Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.extensions.pdlib: init at 1.0.2 #107855

Merged
merged 1 commit into from Jan 9, 2021
Merged

php.extensions.pdlib: init at 1.0.2 #107855

merged 1 commit into from Jan 9, 2021

Conversation

aanderse
Copy link
Member

Motivation for this change

Resolves #91857.

Counting on @turion for testing... I don't even know what this package is 🤷‍♂️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27, globin, etu and talyz December 28, 2020 23:49
@aanderse
Copy link
Member Author

@GrahamcOfBorg build php73.extensions.pdlib php74.extensions.pdlib php80.extensions.pdlib

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107855 run on x86_64-linux 1

3 packages built:
  • php73Extensions.pdlib
  • phpExtensions.pdlib (php74Extensions.pdlib)
  • php80Extensions.pdlib

@turion
Copy link
Contributor

turion commented Dec 29, 2020

Thanks a lot!

I don't even know what this package is 🤷‍♂️

This is needed to make this nextcloud app work:

https://apps.nextcloud.com/apps/facerecognition

I guess I'm going to try and find out how that is done.

@aanderse aanderse merged commit 9bbc363 into NixOS:master Jan 9, 2021
@aanderse aanderse deleted the php/pdlib branch January 9, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@etu etu etu approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pdlib
4 participants
@aanderse @SuperSandro2000 @turion @etu