Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.wordcloud: 1.6.0 -> 1.8.1 #107906

Merged
merged 1 commit into from Jan 1, 2021
Merged

python3.pkgs.wordcloud: 1.6.0 -> 1.8.1 #107906

merged 1 commit into from Jan 1, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jm2dev December 29, 2020 21:32
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107906 run on x86_64-linux 1

3 packages built:
  • python37Packages.wordcloud
  • python38Packages.wordcloud
  • python39Packages.wordcloud

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107906 run on x86_64-darwin 1

3 packages built:
  • python37Packages.wordcloud
  • python38Packages.wordcloud
  • python39Packages.wordcloud

@Mic92 Mic92 force-pushed the wordcloud branch 2 times, most recently from eaa033a to dec1308 Compare December 30, 2020 05:23
@Mic92
Copy link
Member Author

Mic92 commented Dec 30, 2020

Applied an upstream patch as well.

jonringer
jonringer reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildPythonPackage's checkInputs maps to mkDerivation's installCheckInputs

pkgs/development/python-modules/wordcloud/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wordcloud/default.nix Outdated Show resolved Hide resolved
@Mic92 @SuperSandro2000 @jonringer
python3.pkgs.wordcloud: 1.6.0 -> 1.8.1
5d84589 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com>
@Mic92
Copy link
Member Author

Mic92 commented Dec 30, 2020

pytestCheckHook somehow does not pick up the cython module. a manual check phase works however. I also added $out/bin to PATH to fix the other cli check.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107906 run on x86_64-darwin 1

3 packages built:
  • python37Packages.wordcloud
  • python38Packages.wordcloud
  • python39Packages.wordcloud

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107906 run on x86_64-linux 1

3 packages built:
  • python37Packages.wordcloud
  • python38Packages.wordcloud
  • python39Packages.wordcloud

@Mic92 Mic92 merged commit 60c6607 into NixOS:master Jan 1, 2021
@Mic92 Mic92 deleted the wordcloud branch January 1, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jm2dev jm2dev Awaiting requested review from jm2dev

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @SuperSandro2000 @jonringer