New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxkbcommon: 0.10.0 -> 1.0.3 #108004
libxkbcommon: 0.10.0 -> 1.0.3 #108004
Conversation
cc: @jtojnar @worldofpeace since you reviewed/merged last time. Thanks ❤️ ! (er, a bit pre-emptive, I could've waited until my |
In the NEWS, the following items caught my attention:
|
Please rebase this against the |
/rebase-staging |
c29db02
to
c38eeae
Compare
@jtojnar my ten cents:
Well, I think it is a case for multiple outputs.
I think it can be both. The upstream's rationale is this:
Wait for the worst. Certainly it will seek configurations in the three paths above. |
Please don't let this PR stop someone else from picking it up. I'd drafted it thinking it would just be a version bump. It could be a while before I have time to really focus on this, sorry. |
Ok, thanks for the update, I'll try to take care of the rest.
It is new and optional so I'd disable it for now. Installing it into a separate output seems like a nice idea but I think we should add a Meson option to install it into a different prefix first (after this PR).
Update: Fixed now (was
Update: Yes, it works (though I didn't test all subcommands). |
Relevant changes: - Add libxml2 as a required dependency - Disable libxkbregistry for now (a new but optional library -> install into a dedicated output when we need it) - Set the lookup path for system data files to /etc/xkb - Enable the tests - Extend the meta attributes and minor code style changes Co-Authored-By: Cole Mickens <cole.mickens@gmail.com>
I tested this with |
I've had some time to look into this and opened #110773 with a brief reasoning for my approach. Feel free to add your thoughts/opinions or other feedback. |
Motivation for this change
This updates
libxkbcommon
from0.10.0
to latest stable,1.0.3
.Fixes #108003.
This is currently a draft since I haven't run
nixpkgs-review
since I'm expecting a huge rebuild.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)