New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brave: add update script #108029
brave: add update script #108029
Conversation
The Brave package often seems to get very outdated. This is bad for a browser, where vulnerabilities are high impact. This change adds an update script, so that r-ryantm will suggest updates. We find the latest version using their Debian package database (since we are using the Debian package anyway).
Great idea, I knew we needed such a script but I didn't know how to do it. I ran the script, my results are consistent with yours A quick suggestion from my experience looking at a few brave PRs: the list of shared objects has to be maintained by hand. An easy way to know if it's good is to just run Edit: whoops, this isn't well cropped. |
fleshed out my suggestion: doInstallCheck = true;
installCheckPhase = ''
# call directly because upstream wrapper suppresses errors
$out/opt/brave.com/brave/brave --version
''; If you intentionally mess up the rpath:
Otherwise, it passes |
Sounds good! Could you open a PR for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for working on it @danieldk .
Thanks for the reviews! 👍 |
Motivation for this change
The Brave package often seems to get very outdated. This is bad for a
browser, where vulnerabilities are high impact.
This change adds an update script, so that r-ryantm will suggest
updates. We find the latest version using their Debian package
database (since we are using the Debian package anyway).
While at it, use the update script to update Brave ;):
brave: 1.18.75 -> 1.18.77
Changelog:
https://community.brave.com/t/release-channel-1-18-77/191009
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)