New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signumone-ks: init at 3.1.2 #108191
signumone-ks: init at 3.1.2 #108191
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
installPhase = '' | ||
DESKTOP_PATH=$out/share/applications/signumone-ks.desktop | ||
|
||
mkdir -p $out/{bin,share/applications} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdir -p $out/{bin,share/applications} | |
mkdir -p $out/bin $out/share/applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
mv opt/SignumOne-KS/SignumOne-KS.desktop $DESKTOP_PATH | ||
mv opt $out | ||
|
||
sed -e "s|\(Exec=\)/opt/SignumOne-KS|\1$out/bin|g" -i $DESKTOP_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use substituteInPlace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in force-pushed commit
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch) Result of 1 package built:
|
730065e
to
17fafad
Compare
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
||
buildInputs = [ | ||
atk glibc gdk-pixbuf stdenv.cc.cc ffmpeg | ||
libav_0_8 gtk3 libXtst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt we need both ffmpeg
and libav_0_8
.
Also, shouldn't glibc
and stdenv.cc.cc
automatically be added by stdenv.mkDerivation
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not adding libav_0_8
will not build.
autoPatchelfHook could not satisfy dependency libavcodec-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
autoPatchelfHook could not satisfy dependency libavcodec.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavcodec.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavcodec.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavcodec.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so
autoPatchelfHook could not satisfy dependency libavformat.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so
autoPatchelfHook could not satisfy dependency libavformat.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so
autoPatchelfHook could not satisfy dependency libavformat.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so
autoPatchelfHook could not satisfy dependency libavformat.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so
autoPatchelfHook could not satisfy dependency libavformat.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so
/nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I forgot that it is ignoring missing deps. It is running as expected. Going to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not adding
libav_0_8
will not build.autoPatchelfHook could not satisfy dependency libavcodec-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so autoPatchelfHook could not satisfy dependency libavcodec.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so autoPatchelfHook could not satisfy dependency libavcodec.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so autoPatchelfHook could not satisfy dependency libavcodec.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so autoPatchelfHook could not satisfy dependency libavcodec.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so autoPatchelfHook could not satisfy dependency libavcodec.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so autoPatchelfHook could not satisfy dependency libavformat-ffmpeg.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-56.so autoPatchelfHook could not satisfy dependency libavformat.so.54 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-54.so autoPatchelfHook could not satisfy dependency libavformat.so.55 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-55.so autoPatchelfHook could not satisfy dependency libavformat.so.56 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-56.so autoPatchelfHook could not satisfy dependency libavformat.so.57 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-ffmpeg-57.so autoPatchelfHook could not satisfy dependency libavformat.so.53 wanted by /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3/opt/SignumOne-KS/runtime/lib/amd64/libavplugin-53.so /nix/store/zzzb60wwkcyq71n1h8gk6idjx66djzd6-signumone-ks-3.1.3
This probably means it requires libav_0_8
, but not ffmpeg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you should be fine with ffmpeg_3:
$ nix-build -A ffmpeg_3
$ ls result/lib
libavcodec.so libavfilter.so.6 libavresample.so.3.7.0 libswresample.so
libavcodec.so.57 libavfilter.so.6.107.100 libavutil.so libswresample.so.2
libavcodec.so.57.107.100 libavformat.so libavutil.so.55 libswresample.so.2.9.100
libavdevice.so libavformat.so.57 libavutil.so.55.78.100 libswscale.so
libavdevice.so.57 libavformat.so.57.83.100 libpostproc.so libswscale.so.4
libavdevice.so.57.10.100 libavresample.so libpostproc.so.54 libswscale.so.4.8.100
libavfilter.so libavresample.so.3 libpostproc.so.54.7.100
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)