boot.loader.grub: add extraInstallCommands option #108242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/is-it-possible-to-have-a-config-system-overlay/10783/4 |
otavio
suggested changes
Jan 3, 2021
GovanifY
force-pushed
the
grub-additional
branch
from
39f5c4d
to
771ba47
Compare
otavio
approved these changes
Jan 3, 2021
|
For me it's fine. I cannot merge it so I think someone else needs to review it. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@GrahamcOfBorg test installer |
|
@GrahamcOfBorg test grub |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We might want to execute some commands after the bootloader has been installed along with its menu entires, eg for signature checks. This option adds an easy way to do that for GRUB.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)