Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiteur: jailbreak and un-break #108452

Merged
merged 2 commits into from Jan 8, 2021
Merged

profiteur: jailbreak and un-break #108452

merged 2 commits into from Jan 8, 2021

Conversation

cleverca22
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cleverca22 cleverca22 mentioned this pull request Jan 5, 2021
Merged
cdepillabout
cdepillabout requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on the haskell-updates branch (instead of master)?

Also, could you remove profiteur from the list of broken-packages in configuration-hackage2nix.yaml?

@cleverca22 cleverca22 changed the base branch from master to haskell-updates January 5, 2021 07:36
@cleverca22
Copy link
Contributor Author

@cdepillabout done!

@jbgi jbgi requested a review from cdepillabout January 5, 2021 08:50
@sternenseemann
Copy link
Member

Builds and seems to run fine on x86_64-linux.

@cdepillabout
Copy link
Member

@cleverca22 Thanks for working with us on this!

@cdepillabout cdepillabout merged commit 08fc5ef into NixOS:haskell-updates Jan 8, 2021
@cleverca22 cleverca22 deleted the jailbreak-profiteur branch January 8, 2021 13:11
@cleverca22
Copy link
Contributor Author

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleverca22 @sternenseemann @cdepillabout