monado: init at 0.4.1

[prusnak]

Motivation for this change

Monado is an open source XR runtime delivering immersive experiences such as VR and AR on mobile, PC/desktop, and other devices. Monado aims to be a complete and conformant implementation of the OpenXR API made by Khronos.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[prusnak]

@GrahamcOfBorg build monado

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108577 run on x86_64-linux 1

2 packages built:

• libuvc
• monado

[expipiplus1]

Like libsurvive, there was already an approved PR open for this with more features: #107001

[expipiplus1]

@prusnak and @SuperSandro2000. Perhaps you would be so kind as to integrate the valuable changes there (the serviceSupport option, the differing dependencies (not sure which is more correct) and the libsurvive detection can be done with the flag or the patch (probably not worth changing)) into the merged packages?

[prusnak]

@expipiplus1 Sorry, I missed your PR. Can you please rebase your PR #107001 on top of the current master and I'll review it.

[expipiplus1]

@prusnak I've rebased and it's on https://github.com/expipiplus1/nixpkgs/tree/joe-xr2, did you mean for me to rebase as well as resolving the (logical) conflicts?

[prusnak]

did you mean for me to rebase as well as resolving the (logical) conflicts?

Yes. Pull in the latest master (your master is 29 commits behind) and rebase on top of it resolving all the conflicts.
You can force push to the joe-xr branch - it will update the PR #107001 automatically. We'll review the changes afterwards.

Sorry for causing this mess, but rebasing should not be that big issue.

[expipiplus1]

Are those 29 commits relevant, 😂? There are no textual conflicts as we chose to put the monado directory and attributes in different places. If it's all the same to you I think I'd prefer if you or sandro would perform the merge as I've been feeling a little demoralised with nixpkgs PRs recently and don't feel like running that gauntlet again at the moment, especially for a contribution I've already done once.

…

On Sat, Jan 9, 2021, 1:43 AM Pavol Rusnak ***@***.***> wrote: did you mean for me to rebase as well as resolving the (logical) conflicts? Yes. Pull in the latest master (your master is 29 commits behind) and rebase on top of it resolving all the conflicts. You can force push to the joe-xr branch - it will update the PR #107001 <#107001> automatically. We'll review the changes afterwards. Sorry for causing this mess, but rebasing should not be that big issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#108577 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXAVSKYID7LUXBNCUSTSY4733ANCNFSM4VXMRKTA> .

[prusnak]

@expipiplus1 OK, I'll take your PR changes and rework in on top of my changes. Will then close your PR and open a new one from my branch. I'll ping you once it's done, so you can help with the review.

[expipiplus1]

That's very kind of you, thank you.

…

On Sat, Jan 9, 2021, 2:01 AM Pavol Rusnak ***@***.***> wrote: @expipiplus1 <https://github.com/expipiplus1> OK, I'll take your PR changes and rework in on top of my changes. Will then close your PR and open a new one from my branch. I'll ping you once it's done, so you can help with the review. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#108577 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXGM5DDPSCG2HUCP6RTSY5B45ANCNFSM4VXMRKTA> .