Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: explicitly mark broken for failed building apple packages #108651

Merged
merged 2 commits into from Jan 16, 2021
Merged

darwin: explicitly mark broken for failed building apple packages #108651

merged 2 commits into from Jan 16, 2021

Conversation

holymonson
Copy link
Contributor

Motivation for this change

We are trying to update and clean apple packages, so we explicitly mark broken for those mean to fail building.

Things done

Mark hfs and libauto broken.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@holymonson holymonson mentioned this pull request Jan 7, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Please move those two changes into two commits and name them properly. I imagine something like darwin.libaudio: mark broken.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021 •
edited

Result of nixpkgs-review pr 108651 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • darwin.hfs
  • darwin.libauto

Can you also make those packages darwin only?

@SuperSandro2000
Copy link
Member

@holymonson please resolve the eval error.

@holymonson holymonson changed the title explicitly mark broken for failed building apple packages darwin: explicitly mark broken for failed building apple packages Jan 7, 2021
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-linux: 0 and removed 10.rebuild-linux: 1-10 labels Jan 7, 2021
@veprbl veprbl merged commit eeaca31 into NixOS:master Jan 16, 2021
@holymonson holymonson deleted the mark-broken branch January 17, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holymonson @SuperSandro2000 @veprbl