Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networking: make /etc/netgroup by default #108726

Merged
merged 1 commit into from Jan 10, 2021

Conversation

omasanori
Copy link
Contributor

Motivation for this change

I had removed the PR branch for #102870 by mistake so the PR was closed and unable to be reopened. Thus I restart a PR here. This is my fault, sorry.

NixOS now generates an empty file /etc/netgroup by default. It will suppress the "/etc/netgroup: No such file or directory" messages from nscd.
Inspired by #68671 but I changed config/networking.nix instead of services/networking/nscd.nix since the file is not specific to glibc.

Fixes #68603

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This will prevent nscd from complaining /etc/netgroup being absent.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori omasanori requested a review from flokli January 10, 2021 02:03
@flokli flokli merged commit 5812324 into NixOS:master Jan 10, 2021
@flokli
Copy link
Contributor

flokli commented Jan 10, 2021

Thanks!

@omasanori omasanori deleted the nixos/netgroup branch January 11, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nscd complaining about not finding /etc/netgroup
2 participants