Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyhaversion: 3.4.2 -> 20.12.1 #108777

Merged
merged 2 commits into from Jan 13, 2021
Merged

python3Packages.pyhaversion: 3.4.2 -> 20.12.1 #108777

merged 2 commits into from Jan 13, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 8, 2021 •
edited

Motivation for this change

Update to latest upstream release 20.12.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all the python3Packages.pyhaversion commits.

@ofborg ofborg bot requested a review from makefu January 8, 2021 15:55
@fabaff
Copy link
Member Author

fabaff commented Jan 9, 2021

Please squash all the python3Packages.pyhaversion commits.

Done. Squashed back till update but leave update commit in place in case we have to revert back to 3.4.2.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108777 run on x86_64-darwin 1

1 package failed to build and are new build failure:
3 packages built:
  • python37Packages.awesomeversion
  • python38Packages.awesomeversion
  • python39Packages.awesomeversion

jonringer
jonringer reviewed Jan 9, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/108777

1 package failed to build:
python37Packages.pyhaversion

3 packages built:
python37Packages.awesomeversion python38Packages.awesomeversion python39Packages.awesomeversion

pkgs/development/python-modules/awesomeversion/default.nix Show resolved Hide resolved
pkgs/development/python-modules/awesomeversion/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108777 run on x86_64-linux 1

1 package failed to build and are new build failure:
3 packages built:
  • python37Packages.awesomeversion
  • python38Packages.awesomeversion
  • python39Packages.awesomeversion

@fabaff
Copy link
Member Author

fabaff commented Jan 10, 2021

Result of nixpkgs-review pr 108777 1

2 packages built:
  • python38Packages.awesomeversion
  • python39Packages.awesomeversion

@SuperSandro2000
Copy link
Member

@fabaff please fix the merge conflict.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108777 run on x86_64-darwin 1

2 packages built:
  • python38Packages.awesomeversion
  • python39Packages.awesomeversion

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108777 run on x86_64-linux 1

2 packages built:
  • python38Packages.awesomeversion
  • python39Packages.awesomeversion

@SuperSandro2000 SuperSandro2000 merged commit e6a184a into NixOS:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @jonringer