Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-x11.stable: 455.45.01 -> 460.32.03 #108795

Merged
merged 1 commit into from Jan 9, 2021

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Jan 8, 2021

Motivation for this change

Driver update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianhjr
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 8, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 8, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@fabianhjr
Copy link
Member Author

Tried it yesterday for Cyberpunk and AC via Proton. Not particularly more stable.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108795 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.nvidia_x11
  • linuxPackages_hardkernel_latest.nvidia_x11
4 packages failed to build and are new build failures:
27 packages built:
  • bumblebee
  • geekbench
  • linuxPackages.nvidia_x11 (linuxPackages_5_4.nvidia_x11)
  • linuxPackages_4_14.nvidia_x11
  • linuxPackages_4_19.nvidia_x11
  • linuxPackages_4_4.nvidia_x11
  • linuxPackages_4_9.nvidia_x11
  • linuxPackages_5_10.nvidia_x11 (linuxPackages_latest.nvidia_x11)
  • linuxPackages_5_9.nvidia_x11
  • linuxPackages_hardened.nvidia_x11
  • linuxPackages_latest-libre.nvidia_x11
  • linuxPackages_latest_hardened.nvidia_x11
  • linuxPackages_latest_xen_dom0.nvidia_x11
  • linuxPackages_latest_xen_dom0_hardened.nvidia_x11
  • linuxPackages_lqx.nvidia_x11
  • linuxPackages_testing_bcachefs.nvidia_x11
  • linuxPackages_xen_dom0.nvidia_x11
  • linuxPackages_xen_dom0_hardened.nvidia_x11
  • linuxPackages_zen.nvidia_x11
  • primus
  • psensor
  • python37Packages.TheanoWithCuda
  • python37Packages.pytorch-bin
  • python38Packages.TheanoWithCuda
  • python38Packages.pytorch-bin
  • python39Packages.TheanoWithCuda
  • python39Packages.pytorch-bin

@SuperSandro2000 SuperSandro2000 merged commit 9ffdffc into NixOS:master Jan 9, 2021
@danieldk
Copy link
Contributor

danieldk commented Jan 10, 2021

This version bump seems to have broken passthru.settings:

nix-build -A linuxPackages.nvidia_x11.passthru.settings
this derivation will be built:
  /nix/store/4dbvnmar7mgsnpklf6jn1kly02wqf5g1-nvidia-settings-460.27.04.drv
building '/nix/store/4dbvnmar7mgsnpklf6jn1kly02wqf5g1-nvidia-settings-460.27.04.drv'...
unpacking sources
unpacking source archive /nix/store/5cjb5wqp5jxmdhzldxmpywsc9gq048i6-source
source root is source
patching sources
configuring
no configure script, doing nothing
building
build flags: -j16 -l16 SHELL=/nix/store/zcl19h06322c3kss6bvf05w2pxg4kfll-bash-4.4-p23/bin/bash NV_USE_BUNDLED_LIBJANSSON=0
make[1]: Entering directory '/build/source/src'
/nix/store/zcl19h06322c3kss6bvf05w2pxg4kfll-bash-4.4-p23/bin/bash: _out/Linux_x86_64/antialias.png.h: No such file or directory
make[1]: *** [Makefile:320: _out/Linux_x86_64/antialias.png.h] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/source/src'
make: *** [Makefile:23: all] Error 2
error: --- Error ----------------------------------------------------- nix-build
builder for '/nix/store/4dbvnmar7mgsnpklf6jn1kly02wqf5g1-nvidia-settings-460.27.04.drv' failed with exit code 2; last 10 log lines:
  configuring
  no configure script, doing nothing
  building
  build flags: -j16 -l16 SHELL=/nix/store/zcl19h06322c3kss6bvf05w2pxg4kfll-bash-4.4-p23/bin/bash NV_USE_BUNDLED_LIBJANSSON=0
  make[1]: Entering directory '/build/source/src'
  /nix/store/zcl19h06322c3kss6bvf05w2pxg4kfll-bash-4.4-p23/bin/bash: _out/Linux_x86_64/antialias.png.h: No such file or directory
  make[1]: *** [Makefile:320: _out/Linux_x86_64/antialias.png.h] Error 1
  make[1]: *** Waiting for unfinished jobs....
  make[1]: Leaving directory '/build/source/src'
  make: *** [Makefile:23: all] Error 2

@fabianhjr
Copy link
Member Author

I aplogize, when this release landed there wasn't a corresponding release of nvidia-settings si I went with the latest 460 series settings release.

I have no idea if passthrough settings will unbreak bumping it to 460.32.03 but could either open a revert or bump the settings version.

@baracoder
Copy link
Contributor

Can confirm it working corresponding nvidia-settings version. Had it in a local branch and on my machine for a few days.

diff --git a/pkgs/os-specific/linux/nvidia-x11/default.nix b/pkgs/os-specific/linux/nvidia-x11/default.nix
index a57611ecb1d..423ce85e8c4 100644
--- a/pkgs/os-specific/linux/nvidia-x11/default.nix
+++ b/pkgs/os-specific/linux/nvidia-x11/default.nix
@@ -24,8 +24,7 @@ rec {
     then generic {
       version = "460.32.03";
       sha256_64bit = "0qb0f8djys55b7qgvpbwafw5lkwvmcslqz3i2kr3jm354gy248ag";
-      settingsVersion = "460.27.04";
-      settingsSha256 = "1z9ibkhyjqzhhzi3gj88f5jlpc1d76jsncsy6wxpnbdbak8ljkw5";
+      settingsSha256 = "dKBYoxbiMxWnB78VHo4gLLl5510zXBaO6S34RzTg01U=";
       persistencedSha256 = "36sM+djZmv77lGe7cdZ5tppzgkQD4IA0FJgCGsdZRI8=";
     }
     else legacy_390;

There is a warning in dmesg when starting nvidia-settings, but it works. This might be a bug in nvidia-settings

[162443.410254] NVRM: API mismatch: the client has the version 440.82, but
                NVRM: this kernel module has the version 460.32.03.  Please
                NVRM: make sure that this kernel module and all NVIDIA driver
                NVRM: components have the same version.

@fabianhjr
Copy link
Member Author

fabianhjr commented Jan 24, 2021

Hey @danieldk, I observed similar errors recently but the odd thing is that rerunning the build will subsequently succeed. Seems like for some odd reason the nvidia-settings build became (or was) flaky.

EDIT: To clarify, happened twice in the last week and I try to rebuild daily at the end of the day.

@baracoder baracoder mentioned this pull request May 13, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants