treewide: stdenv.lib -> lib

[siraben]

Motivation for this change

Further progress on #108938. References to stdenv.lib are still plenty abound, to make reviewing and debugging easier I'm performing changes to entire subdirectories in separate commits (will be squashed at the end). The process was initially manual but I've mostly automated it.

I would run the following command and discard changes on non-Nix files.

$ nix-shell -p coreutils # macOS sed behaves differently
$ find pkgs/applications -type f -print0 | xargs -0 sed --in-place='' -E "s/stdenv\.lib/lib/"

Then I made a step.sh

#! /usr/bin/env nix-shell
#! nix-shell --pure -i bash -p coreutils nix

# Find the file with the evaluation error
theFile=$(nix-env -f . -qaP --xml --out-path --show-trace --meta 2>&1 >/dev/null | sed -E "s/.*'lib'.*at (.*):.*:.*/\1/" | tail -n 1)
# Print it
echo "$theFile"
# Replace the first occurence of stdenv with lib, stdenv
sed --in-place='' '0,/stdenv/s/stdenv/lib, stdenv/' "$theFile"

Then I ran

$ while true; do ./step.sh; done
./nixpkgs/pkgs/applications/networking/mailreaders/imapfilter.nix
./nixpkgs/pkgs/applications/networking/iptraf/default.nix
./nixpkgs/pkgs/applications/networking/irc/irssi/default.nix
...

Whenever an error appeared, I interrupted and fixed it manually. Some interesting errors I found after the replacement were

• let lib = stdenv.lib (leads to infinite recursion)

• applications

• data

• desktops

• development

• games

• misc

• os-specific

• servers

• shells

• tools

• top-level

[siraben]

Rebased on staging-next because of all the whitespace errors.

[jonringer]

LGTM

assuming no rebuilds, or package changes

[siraben]

@jonringer Should I rebase on master? If this gets merged to master, and staging-next has my whitespace cleanups, won't we have a merge conflict when we try to merge staging-next into master?

[siraben]

On second thought, this is a harmless change and the goal is quicker deprecation of stdenv.lib, so I will rebase on master.

[SuperSandro2000]

@siraben can you please take a look at the rebuilds ofborg listed and move them to a separate PR?

[Mic92]

It is worldofgoo, sil and mendeley.

[siraben]

@SuperSandro2000 I took a look at the changed paths.

• worldofgoo is changed because of trailing whitespace in unpackPhase
• sil is changed because of trailing whitespace in prePatch
• mendeley is changed because of trailing whitespace in installPhase

None of these changes affect the build in any way.

[Mic92]

@SuperSandro2000 I took a look at the changed paths.

* worldofgoo is changed because of trailing whitespace in unpackPhase

* sil is changed because of trailing whitespace in prePatch

* mendeley is changed because of trailing whitespace in installPhase

None of these changes affect the build in any way.

I am fine with those changes. The would otherwise affect the editorconfig ci check.