Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcitx5: 5.0.3 -> 5.0.4 #109426

Merged
merged 13 commits into from Jan 22, 2021
Merged

Conversation

poscat0x04
Copy link
Contributor

Things done
  1. Update fcitx5 and related packages.
  2. Add an update script
  3. Centralize sources
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/444

@SuperSandro2000
Copy link
Member

Also please fix the merge conflict.

@poscat0x04
Copy link
Contributor Author

should be good now

@poscat0x04
Copy link
Contributor Author

ping @SuperSandro2000

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109426 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
14 packages built:
  • fcitx5
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-gtk
  • fcitx5-lua
  • fcitx5-rime
  • fcitx5-table-extra
  • fcitx5-table-other
  • fcitx5-with-addons
  • libime
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt
  • xcb-imdkit

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

fcitx5-lua:

An avoidable string conversion got detected: rev = "${version}";
Please do not convert version to a string if you do not prepend a string like v.

@poscat0x04
Copy link
Contributor Author

May I ask what is preventing this PR from being merged?

@SuperSandro2000
Copy link
Member

May I ask what is preventing this PR from being merged?

Me not having more time.

@poscat0x04
Copy link
Contributor Author

Ah no worries, take your time.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109426 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
14 packages built:
  • fcitx5
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-gtk
  • fcitx5-lua
  • fcitx5-rime
  • fcitx5-table-extra
  • fcitx5-table-other
  • fcitx5-with-addons
  • libime
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt ,plasma5Packages.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt
  • xcb-imdkit

@SuperSandro2000 SuperSandro2000 merged commit a252b7e into NixOS:master Jan 22, 2021
@poscat0x04 poscat0x04 deleted the fcitx-update-script branch August 16, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants