keepassxc: 2.6.2 -> 2.6.3

[claudiiii]

Motivation for this change

Version 2.6.3 was released a while ago.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[claudiiii]

Result of nixpkgs-review pr 109800 run on x86_64-darwin 1

1 package built:

• keepassxc (keepassx2-http)

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109800 run on x86_64-darwin 1

1 package failed to build and already failed to build on hydra master:

• keepassxc: log https://termbin.com/k2sm

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

keepassxc:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '/usr/local/bin' doesn't match anything in file 'CMakeLists.txt'
substituteStream(): WARNING: pattern '/usr/local/share/man' doesn't match anything in file 'CMakeLists.txt'

Please check the offending substituteInPlace for typos or changes in source.
�[1;33mwarning: build-tools-in-build-inputs�[0m
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/misc/keepassx/community.nix:95:3:

   |
95 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
�[1;33mwarning: missing-phase-hooks�[0m
checkPhase should probably contain runHook preCheck and runHook postCheck.

Near pkgs/applications/misc/keepassx/community.nix:85:3:

   |
85 |   checkPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
�[1;33mwarning: unclear-gpl�[0m
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/misc/keepassx/community.nix:127:5:

    |
127 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

[claudiiii]

I fixed the issues detected by nixpkgs-hammering and can reproduce the darwin failure locally when using a sandboxed build. It seems like this is the same error as #97194.

[turion]

I fixed the issues detected

Are these fixes necessary for the version to progress? If not, can you separate the commits?

[SuperSandro2000]

Are these fixes necessary for the version to progress? If not, can you separate the commits?

It is fine to put them in the version update. Otherwise we would accumulate way to many commits in this repo.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109800 run on x86_64-linux 1

1 package built:

• keepassxc

[claudiiii]

I created a backport pr in #110921.