New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notcurses: 2.1.0 -> 2.1.5 #109929
Merged
Merged
notcurses: 2.1.0 -> 2.1.5 #109929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to update the sha256 as well.
You can do this by changing the hash by 1 character and then running:
nix-build . -A notcurses
Looks like it's:
02x9a0z7mbgry2wsfai1l3jwb2zpcg4gq6a2w5d920ap2fixzy8b
|
damn it, i knew as much, but somehow overlooked it. thanks! fixing now. |
i assume that's just |
updated. |
Nick Black <notifications@github.com> writes:
updated.
Looks like it needs readline80 to build. Here's an updated patch:
https://jb55.com/s/0e047035c8a47c37.txt
Cheers,
jb55
|
well i really ought set up a nix VM to do this, oughtn't i? embarrassing |
updated. thanks a lot! |
Nick Black <notifications@github.com> writes:
updated. thanks a lot!
LGTM. ACK 81ca24f
I would merge but I can't.
Cheers,
jb55
|
tomberek
approved these changes
Jan 30, 2021
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bring Notcurses up-to-date in NixOS. 2.1.0 was the first version packaged, and it took a few iterations to get there, hence the distance from head. Future updates ought span fewer versions. This is my first NixOS submission, so please be gentle =].
dankamongmen/notcurses#1290
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)