Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notcurses: 2.1.0 -> 2.1.5 #109929

Merged
merged 1 commit into from Feb 25, 2021
Merged

notcurses: 2.1.0 -> 2.1.5 #109929

merged 1 commit into from Feb 25, 2021

Conversation

dankamongmen
Copy link
Contributor

Motivation for this change

Bring Notcurses up-to-date in NixOS. 2.1.0 was the first version packaged, and it took a few iterations to get there, hence the distance from head. Future updates ought span fewer versions. This is my first NixOS submission, so please be gentle =].

dankamongmen/notcurses#1290

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jb55
Copy link
Contributor

jb55 commented Jan 19, 2021 via email

@dankamongmen
Copy link
Contributor Author

damn it, i knew as much, but somehow overlooked it. thanks! fixing now.

@dankamongmen
Copy link
Contributor Author

i assume that's just sha256sum -b archive? yeah, it appears so.

@dankamongmen
Copy link
Contributor Author

updated.

@jb55
Copy link
Contributor

jb55 commented Jan 19, 2021 via email

@dankamongmen
Copy link
Contributor Author

well i really ought set up a nix VM to do this, oughtn't i? embarrassing

@dankamongmen
Copy link
Contributor Author

updated. thanks a lot!

@jb55
Copy link
Contributor

jb55 commented Jan 19, 2021 via email

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 109929 run on x86_64-linux 1

1 package built:
  • notcurses

@tomberek tomberek merged commit 6cae2af into NixOS:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants