Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlc: 3.0.11.1 -> 3.0.12 #110379

Merged
merged 1 commit into from Jan 24, 2021
Merged

vlc: 3.0.11.1 -> 3.0.12 #110379

merged 1 commit into from Jan 24, 2021

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Jan 21, 2021

Motivation for this change

Security issue https://www.videolan.org/security/sb-vlc3012.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110379 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.elisa
  • libsForQt514.elisa
1 package failed to build and are new build failure:
  • obs-ndi: log was empty
18 packages built:
  • libsForQt5.elisa (libsForQt515.elisa ,plasma5Packages.elisa)
  • libsForQt5.phonon-backend-vlc (libsForQt515.phonon-backend-vlc ,plasma5Packages.phonon-backend-vlc)
  • libsForQt512.phonon-backend-vlc
  • libsForQt514.phonon-backend-vlc
  • libvlc
  • megaglest
  • minitube
  • obs-move-transition
  • obs-studio
  • obs-v4l2sink
  • obs-wlrobs
  • pympress
  • python37Packages.python-vlc
  • python38Packages.python-vlc
  • python39Packages.python-vlc
  • strawberry
  • tribler
  • vlc (vlc_qt5)

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

libvlc:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'configure'

Please check the offending substituteInPlace for typos or changes in source.

vlc:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'configure'

Please check the offending substituteInPlace for typos or changes in source.

@tu-maurice
Copy link
Contributor Author

tu-maurice commented Jan 23, 2021

@SuperSandro2000 I removed the offending substituteInPlace. I presume obs-ndi did not build for you because a dependency is unfree and/or requires a manual download of sources?

@SuperSandro2000
Copy link
Member

I presume obs-ndi did not build for you because a dependency is unfree and/or requires a manual download of sources?

It requires a manual download.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110379 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.elisa
  • libsForQt514.elisa
1 package failed to build and are new build failure:
  • obs-ndi: log was empty
18 packages built:
  • libsForQt5.elisa (libsForQt515.elisa ,plasma5Packages.elisa)
  • libsForQt5.phonon-backend-vlc (libsForQt515.phonon-backend-vlc ,plasma5Packages.phonon-backend-vlc)
  • libsForQt512.phonon-backend-vlc
  • libsForQt514.phonon-backend-vlc
  • libvlc
  • megaglest
  • minitube
  • obs-move-transition
  • obs-studio
  • obs-v4l2sink
  • obs-wlrobs
  • pympress
  • python37Packages.python-vlc
  • python38Packages.python-vlc
  • python39Packages.python-vlc
  • strawberry
  • tribler
  • vlc (vlc_qt5)

@SuperSandro2000 SuperSandro2000 merged commit 6bd5519 into NixOS:master Jan 24, 2021
@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 24, 2021
@tu-maurice
Copy link
Contributor Author

@SuperSandro2000 there's a port to stable here: #110386

@tu-maurice tu-maurice deleted the vlc-3.0.12 branch January 24, 2021 11:24
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants