Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk-bin, graalvm8-ce, graalvm11-ce, zulu, zulu8: link jni_md.h to include folder #110567

Merged
merged 3 commits into from
Jul 23, 2021
Merged

adoptopenjdk-bin, graalvm8-ce, graalvm11-ce, zulu, zulu8: link jni_md.h to include folder #110567

merged 3 commits into from
Jul 23, 2021

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 23, 2021 •
edited

Motivation for this change

jni.h expects jni_md.h to be in the header search path.

See also:

openjdk already fixes this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Jan 23, 2021
Closed
Open
@taku0 taku0 marked this pull request as ready for review February 13, 2021 05:23
@taku0
Copy link
Contributor Author

taku0 commented Feb 13, 2021

Rebased on the master. Ready to merge.

@taku0
Copy link
Contributor Author

taku0 commented Feb 13, 2021

rJava is built successfully. Try this:

nix-build -I nixpkgs=. -o rJava -E "let pkgs = (import <nixpkgs> { config = {packageOverrides = pkgs: {jdk = pkgs.zulu8; jdk8 = pkgs.zulu8;};};}); in pkgs.rPackages.rJava"

@taku0 taku0 changed the base branch from master to staging March 6, 2021 08:49
@ofborg ofborg bot added 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: ocaml labels Mar 6, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested review from glittershark, hlolli and fpletz March 21, 2021 22:48
@taku0
Copy link
Contributor Author

taku0 commented Jul 22, 2021

I get a LGTM from the related Issue. Can we merge this?

#109419 (comment)

@SuperSandro2000
Copy link
Member

ping me if asbachb does not react in a few days.

asbachb
asbachb approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@asbachb asbachb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@SuperSandro2000 SuperSandro2000 merged commit 3e712c9 into NixOS:staging Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glittershark glittershark glittershark approved these changes

@asbachb asbachb asbachb approved these changes

@hlolli hlolli Awaiting requested review from hlolli

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @SuperSandro2000 @glittershark @asbachb