Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: 4.4.1 -> 4.4.2 #110574

Merged
merged 1 commit into from Jan 25, 2021
Merged

krita: 4.4.1 -> 4.4.2 #110574

merged 1 commit into from Jan 25, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 23, 2021

Motivation for this change

We can re-enable parallel building, since the bug causing intermittent build issues is now fixed. See https://bugs.kde.org/show_bug.cgi?id=431226 for more information.

Closes #35359.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
krita: 4.4.1 -> 4.4.2
923adfe 
We can re-enable parallel building, since the bug causing intermittent
build issues is now fixed. See
https://bugs.kde.org/show_bug.cgi?id=431226 for more information.

Closes NixOS#35359.
@talyz
Copy link
Contributor Author

talyz commented Jan 23, 2021

@GrahamcOfBorg build krita

@SuperSandro2000
Copy link
Member

@ofborg eval

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 110574 run on x86_64-linux 1

2 packages built:
  • gmic-qt-krita
  • krita

@lovesegfault lovesegfault merged commit 6556b1f into NixOS:master Jan 25, 2021
@talyz talyz deleted the krita-4.4.2 branch January 25, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent issue building Krita (4.0.x)
4 participants
@talyz @SuperSandro2000 @lovesegfault @cole-h