Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

byrd: init at git-20200312 #110831

Closed
wants to merge 1 commit into from
Closed

byrd: init at git-20200312 #110831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions pkgs/applications/terminal-emulators/byrd/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{ stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:
{ lib, stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new. I've always used stdenv.lib; when was this change introduced?

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is new. The change was 18 days ago c06b2b3#diff-b0739f44f25865ddf604159bdc99cc82f3c192f46b92215da2594d3e5747f0b0.

stdenv.lib is eventually removed and doing changes which introduce new occurrences of it are not allowed anymore.


stdenv.mkDerivation {
pname = "byrd";
version = "1.3.2";

src = fetchFromGitHub {
owner = "Flyken271";
repo = "Byrd";
rev = "b65b677ea504592e4d3b45c32bb75342e03956f5";
sha256 = "1d575bly2ywgp8nmsddr976i5w3nvh23h8lak2n4m2rjmm3n9wxg";
};

nativeBuildInputs = [ pkg-config ];
buildInputs = [ vte glib libconfig ];

buildPhase = ''
gcc main.c -o byrd $(pkg-config --libs --cflags vte-2.91 libconfig)
'';

installPhase = ''
mkdir -p $out/bin
install -m 0755 -t $out/bin byrd
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

description = "A simple and easy terminal for Linux written in C";
license = licenses.gpl2Plus;
maintainers = with maintainers; [ anna328p ];
};
}
anna328p marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,8 @@ in

archi = callPackage ../tools/misc/archi { };

byrd = callPackage ../applications/terminal-emulators/byrd {};

cool-retro-term = libsForQt5.callPackage ../applications/terminal-emulators/cool-retro-term { };

eterm = callPackage ../applications/terminal-emulators/eterm { };
Expand Down