Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_rocm.clang: add isClang and llvm passthru #110838

Merged
merged 1 commit into from
Jan 26, 2021
Merged

llvmPackages_rocm.clang: add isClang and llvm passthru #110838

merged 1 commit into from
Jan 26, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 26, 2021

Matches generic clang compilers, and fixes isClang inspection, which
0710308 depends on for the --gcc-toolchain flag to be set up properly.

Motivation for this change

Fixes #110834

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
llvmPackages_rocm.clang: add isClang and llvm passthru
44c4690 
Matches generic clang compilers, and fixes isClang inspection, which
0710308 depends on for the
`--gcc-toolchain` flag to be set up properly.

Fixes rocm-comgr
@danieldk
Copy link
Contributor

@ofborg build rocm-opencl-icd

danieldk
danieldk approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the quick fix!

@danieldk danieldk merged commit 35cd023 into NixOS:master Jan 26, 2021
@r-burns r-burns deleted the rocm branch January 26, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rocm-comgr fails to build
2 participants
@r-burns @danieldk