Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .deepOverride on poppler, glib by moving the default derivation into callPackage call #1115

Closed
wants to merge 1 commit into from

Conversation

MarcWeber
Copy link
Contributor

No description provided.

@MarcWeber
Copy link
Contributor Author

This patch will be important for another patch updating cups which is not ready yet

@vcunat vcunat closed this in 78f7baf Oct 26, 2013
@vcunat
Copy link
Member

vcunat commented Oct 26, 2013

Looks good to me, no hashes change, etc. Pushed.

I'm a bit unsure about the overriding methods and how to behave not to break them. Are these documented somewhere?

@MarcWeber
Copy link
Contributor Author

vcunat: In the current case there was nothing to break because using .override dropped the default derivation in those cases making it impossible to use at all. Those two looked like this: default // { inherit way1; inherit way 2}; When using override the default // thing was gone.
Documentation? Mmh Overriding is very very very complicated - I'm not sure I understand all details myself. Its because __override and similar things play together. In short it means when compiling firefox you can replace a dependency in all prerequisites. Using applyGlobalOverrides is an alternative. See #1120 to learn about the current use case (force using the same ghostscript for multiple packages).

@vcunat
Copy link
Member

vcunat commented Oct 26, 2013

Ah, I think I see now. So the key is that the package attributes are unmodified results of callPackage, then they are overridable.

But on the whole, it would be good to compose some docs on overriding, e.g. on the wiki. If someone who understands it did it, that would be great (if someone like that even exists :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants