rt{audio,midi}: refactor

[OPNA2608]

Motivation for this change

• Nixpkgs-fmt'd
• switched both to CMake
• using xyzSupport pattern & explicit CMake variables for audio APIs
• moved RtAudio's patch into postPatch, way too simple of a fix to really need an in-tree patch file imo
• fixed RtMidi's pkg-config file similar to RtAudio's previously

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111621 run on x86_64-linux 1

4 packages failed to build and are new build failures:

• giada: log https://termbin.com/78ed
• muse: log https://termbin.com/k76r
• pianobooster: log https://termbin.com/btiw
• vcv-rack: log https://termbin.com/rsni

19 packages built:

• csound-qt
• cubicsdr
• gqrx
• gr-ais
• gr-gsm
• gr-osmosdr
• milkytracker
• polyphone
• python37Packages.soapysdr-with-plugins
• python38Packages.soapysdr-with-plugins
• python39Packages.soapysdr-with-plugins
• qradiolink
• rtaudio
• rtl_433
• rtmidi
• sdrangel
• soapyaudio
• soapysdr-with-plugins
• welle-io

[OPNA2608]

Result of nixpkgs-review pr 111621 run on aarch64-linux 1

1 package marked as broken and skipped:

• giada

3 packages failed to build:

• polyphone
• sdrangel
• vcv-rack

16 packages built:

• csound-qt
• cubicsdr
• gqrx
• gr-ais
• gr-gsm
• gr-osmosdr
• pianobooster
• python37Packages.soapysdr-with-plugins
• python38Packages.soapysdr-with-plugins
• python39Packages.soapysdr-with-plugins
• qradiolink
• rtaudio
• rtl_433
• rtmidi
• soapyaudio
• soapysdr-with-plugins

(build failures all replicable on master)

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111621 run on x86_64-darwin 1

3 packages marked as broken and skipped:

• giada
• rtl_433
• welle-io

1 package failed to build and already failed to build on hydra master:

• rtmidi: log https://termbin.com/6kho

1 package built:

• rtaudio

Please apply the darwin patch:

diff --git a/pkgs/development/libraries/audio/rtmidi/default.nix b/pkgs/development/libraries/audio/rtmidi/default.nix
index 5ef525f9e11..7f454723a7b 100644
--- a/pkgs/development/libraries/audio/rtmidi/default.nix
+++ b/pkgs/development/libraries/audio/rtmidi/default.nix
@@ -9,7 +9,9 @@
 , jackSupport ? true
 , jack
 , coremidiSupport ? stdenv.hostPlatform.isDarwin
+, CoreAudio
 , CoreMIDI
+, CoreServices
 }:
 
 stdenv.mkDerivation rec {
@@ -49,7 +51,7 @@ stdenv.mkDerivation rec {
 
   buildInputs = lib.optional alsaSupport alsaLib
     ++ lib.optional jackSupport jack
-    ++ lib.optional coremidiSupport CoreMIDI;
+    ++ lib.optionals coremidiSupport [ CoreAudio CoreMIDI CoreServices ];
 
   cmakeFlags = [
     "-DRTMIDI_API_ALSA=${if alsaSupport then "ON" else "OFF"}"
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index e5c8fd41013..1c8b6d3c0c0 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -7300,7 +7300,7 @@ in
 
   rtmidi = callPackage ../development/libraries/audio/rtmidi {
     jack = libjack2;
-    inherit (darwin.apple_sdk.frameworks) CoreMIDI;
+    inherit (darwin.apple_sdk.frameworks) CoreAudio CoreMIDI CoreServices;
   };
 
   openmpi = callPackage ../development/libraries/openmpi { };

[OPNA2608]

CoreAudio & CoreServices dependencies added.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111621 run on x86_64-linux 1

23 packages built:

• csound-qt
• cubicsdr
• giada
• gqrx
• gr-ais
• gr-gsm
• gr-osmosdr
• milkytracker
• muse
• pianobooster
• polyphone
• python37Packages.soapysdr-with-plugins
• python38Packages.soapysdr-with-plugins
• python39Packages.soapysdr-with-plugins
• qradiolink
• rtaudio
• rtl_433
• rtmidi
• sdrangel
• soapyaudio
• soapysdr-with-plugins
• vcv-rack
• welle-io

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111621 run on x86_64-darwin 1

3 packages marked as broken and skipped:

• giada
• rtl_433
• welle-io

2 packages built:

• rtaudio
• rtmidi