[WIP] Add: dunst service #11167

matthiasbeyer · 2015-11-20T11:56:21Z

Service defintion for dunst.

Somehow I cannot build my system with this (nixos-rebuild build -I nixpkgs=... gives me error: The optionservices.dunst' defined in /nix/store/.../dunst.nix' does not exist).

Maybe someone can investigate?

Tests will follow...

matthiasbeyer · 2015-11-20T12:28:52Z

Tests added. They do not really test the dunst service by now, but as you can see the dunstrc is not found. I do not know why.

joachifm · 2015-11-20T12:35:08Z

nixos/modules/services/desktops/dunst.nix

+                    '';
+                };
+
+                dmenu = mkOption {


What is the use case for configuring this?

I'm not even sure why there is such an option. I only "ported" the configuration file to a nix expression without thinking too much about the settings.

bendlas · 2015-12-07T18:19:07Z

I've tried using this on top of the current nixos-unstable channel: https://github.com/bendlas/nixpkgs/tree/dunst-service-fail

I get failures in documentation generation

building path(s) ‘/nix/store/zlq97dfabijy4ms5k27wrdacy5gcbag1-nixos-manual’
options-db.xml:7978: namespace error : Failed to parse QName 'http:'
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : error parsing attribute name
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : attributes construct error
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : Couldn't find end of Start Tag http: line 7978
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: namespace error : Failed to parse QName 'http:'
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : error parsing attribute name
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : attributes construct error
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
options-db.xml:7978: parser error : Couldn't find end of Start Tag http: line 7978
<http://developer.gnome.org/pango/stable/PangoMarkupFormat.html>.
      ^
man-configuration.xml:34: element include: XInclude error : could not load options-db.xml, and no fallback was found
./man-pages.xml:8: element refmiscinfo: Relax-NG validity error : Invalid sequence in interleave
./man-pages.xml:34: element include: Relax-NG validity error : Element refsection has extra content: include
./man-pages.xml:29: element refsection: Relax-NG validity error : Element refentry has extra content: refsection
./man-pages.xml:3: element reference: Relax-NG validity error : Element reference failed to validate content
./man-pages.xml fails to validate
manual.xml:39: element include: XInclude error : could not load options-db.xml, and no fallback was found
builder for ‘/nix/store/wnl9sr61cvzayjvs4rdzlj315rk3lcaa-nixos-manpages.drv’ failed with exit code 3
manual.xml:39: element include: Relax-NG validity error : Did not expect element include there
manual.xml:39: element include: Relax-NG validity error : Expecting element example, got include
manual.xml:39: element include: Relax-NG validity error : Expecting element bridgehead, got include
manual.xml:39: element include: Relax-NG validity error : Expecting element annotation, got include
manual.xml:39: element include: Relax-NG validity error : Element appendix failed to validate content
manual.xml fails to validate
builder for ‘/nix/store/pj7n5zzhfnkm4sqwqn9rkmcx40hl0h15-nixos-manual.drv’ failed with exit code 3

matthiasbeyer · 2015-12-07T18:21:34Z

@bendlas : Afaik, this is not yet merged, right? Anyhow, how is the trace you provided related to what I've done in this PR? And how to reproduce?

I will work on this asap, though atm I have not that much time.

bendlas · 2015-12-07T18:49:14Z

@matthiasbeyer I included your commits in my system, because a) I use dunst and b) I wanted to help you test. When I saw those failures, I bisected them back to your commits. For your convenience (and reference), I linked the current unstable channel branch + your 2 commits in my comment. The current unstable builds fine.
I saw the failures by trying to nixos-rebuild with those commits applied, but I assume that you could reproduce by just building the nixos-manual with nix-build (I don't know the command for that offhand)

bendlas · 2015-12-07T19:14:42Z

You can build just the manual from the nixpkgs source root with: nix-build nixos -A config.system.build.manual.manual
The failure is reproducable by this

zimbatm · 2016-04-09T20:56:25Z

What's the status of this PR ?

matthiasbeyer · 2016-04-09T22:48:53Z

@zimbatm I will have a closer look on what's missing tomorrow. I will then either close this PR unmerged or push it to be ready, though I cannot promise anything here!

matthiasbeyer · 2016-04-17T12:37:07Z

Wah, took me a bit longer than 1 days, I'm sorry. I have no longer any interest in this, feel free to reuse commits.

matthiasbeyer · 2016-06-23T15:24:41Z

I'm interested again. I rebased to latest master and will now start working on this, but based on unstable, so I'm able to test it in a VM.

This reverts commit 2c2437bd2432537f3b6da3749e35d0cbb130c326.

matthiasbeyer · 2016-06-23T16:43:21Z

So here we go.

The failure @bendlas reported was indeed caused by this PR, it was the descriptions where the markup was wrong. I simply removed the descriptions (they should be added later, as soon as this is working).

What's working by now: dunst gets started by systemd. Anyways, systemctl status dunst says that the service is dead (killed by SIGSEGV) but notify-send hello still works.

dunst does not find the configuration file written via the config, though.

For people testing this: Put this in your configuration.nix:

  services.dunst = {
    enable = true;

    global = {
      transparency = 50;
      padding = 18;
      horizontalPadding = 18;
    };
    frame = {
      width = 8;
      color = ''#FF0000'';
    };
  };

Dunst should then put the notifications on the right side of the screen and they should be styled rather ugly. The default config shows the notifications on the left side in light blue (when sending notify-send hello for example).

Here is help wanted ... I don't know why dunst does not find the configuration file and I really do not know why systemd reports it crashed when it is actually running.

zimbatm · 2016-06-24T09:27:39Z

Is dunst forking itself by any chance? That would explain why maybe the parent would segfault but the child is still active.

matthiasbeyer · 2016-06-24T09:35:23Z

@zimbatm Dunst seems to be forking, yes. But I also set the Type = "forking" for the systemd options...

zimbatm · 2016-06-24T14:53:17Z

If you can avoid the fork it generally is a good idea. Maybe there is a command-line option for that.

matthiasbeyer · 2016-06-24T15:19:10Z

nope, there is not, sadly.

zimbatm · 2016-06-24T16:10:07Z

Weird, I just ran dunst from the command-line and it's running as foreground process.

matthiasbeyer · 2016-06-24T16:45:09Z

Yeah, it is really weird ... maybe you (or someone else who knows how services on nixos work) can find the problem... but I'm at my wits end.

zimbatm · 2016-06-26T11:13:59Z

nixos/modules/services/desktops/dunst.nix

+
+            serviceConfig = {
+              ExecStart = "${pkgs.dunst}/bin/dunst -config ${dunstConf} ";
+              Type = "forking";


Did you try just removing this line?

I had it without this line before. Didn't help, though.

joachifm · 2016-07-26T12:41:48Z

Is this still being worked on?

matthiasbeyer · 2016-07-26T12:47:03Z

@joachifm I'm still waiting for review here and suggestions what could fix the problem.

joachifm · 2016-07-26T12:48:51Z

Okay, but this is a lot of code that could be replaced simply by adding dunst & to your xinitrc ...

langston-barrett · 2016-10-03T04:26:27Z

Looks like upstream has a pretty strange systemd service which is the basis for this AUR package. Could that hold the key to dunst not dying?

langston-barrett · 2016-10-03T04:28:38Z

nixos/modules/misc/ids.nix

@@ -270,6 +270,7 @@
      toxvpn = 247;
      squeezelite = 248;
      turnserver = 249;
+      dunst = 250;


Doesn't look like these are ever used in the configuration, am I missing something?

joachifm · 2016-10-03T04:32:56Z

@siddharthist that is not a systemd service file. I'm dubious that the aur package actually does anything helpful. See https://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-starting-services for details.

joachifm · 2016-10-03T04:33:28Z

That said, using a dbus service instead of a systemd service might make sense anyhow.

langston-barrett · 2016-10-03T04:59:02Z

@joachifm I've tried a DBus service type, and that gets it to not crash! See #19183. Will add more documentation on the fields tomorrow and hopefully get it mergeable.

Mic92 · 2016-10-06T05:26:26Z

I would favor the new pull request (#19183)

joachifm reviewed Nov 20, 2015
View reviewed changes

domenkozar added the 6.topic: nixos label Dec 2, 2015

matthiasbeyer force-pushed the add-dunst-service branch from ac187fc to 01fc873 Compare December 22, 2015 08:50

pSub added the 2.status: work-in-progress label Feb 22, 2016

matthiasbeyer closed this Apr 17, 2016

matthiasbeyer reopened this Jun 23, 2016

matthiasbeyer force-pushed the add-dunst-service branch from 01fc873 to ccfdd2d Compare June 23, 2016 15:24

matthiasbeyer added 11 commits June 23, 2016 18:38

Add: dunst service

a913884

dunst service: Add test

f111cb7

fixup! Add: dunst service

050ebe1

[REVERT ME] Remove description, to test

bde08f6

Fix ExecStart script

fc47647

Variables instead of string building

974230a

Use a start-script

f58122a

Revert "Use a start-script"

844483e

This reverts commit 2c2437bd2432537f3b6da3749e35d0cbb130c326.

Set Type forking

d47200f

We want the graphical target

6175e4c

Start after the multi-user target

cb9be85

matthiasbeyer force-pushed the add-dunst-service branch from ccfdd2d to cb9be85 Compare June 23, 2016 16:39

zimbatm reviewed Jun 26, 2016
View reviewed changes

joachifm mentioned this pull request Oct 3, 2016

dunst service: init [wip, stalled] #19183

Closed

7 tasks

langston-barrett reviewed Oct 3, 2016

View reviewed changes

Mic92 closed this Oct 6, 2016

matthiasbeyer deleted the add-dunst-service branch October 6, 2016 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add: dunst service #11167

[WIP] Add: dunst service #11167

matthiasbeyer commented Nov 20, 2015

matthiasbeyer commented Nov 20, 2015

joachifm Nov 20, 2015

matthiasbeyer Nov 20, 2015

bendlas commented Dec 7, 2015

matthiasbeyer commented Dec 7, 2015

bendlas commented Dec 7, 2015

bendlas commented Dec 7, 2015

zimbatm commented Apr 9, 2016

matthiasbeyer commented Apr 9, 2016

matthiasbeyer commented Apr 17, 2016

matthiasbeyer commented Jun 23, 2016

matthiasbeyer commented Jun 23, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm Jun 26, 2016

matthiasbeyer Jun 26, 2016

joachifm commented Jul 26, 2016

matthiasbeyer commented Jul 26, 2016

joachifm commented Jul 26, 2016

langston-barrett commented Oct 3, 2016

langston-barrett Oct 3, 2016

joachifm commented Oct 3, 2016

joachifm commented Oct 3, 2016

langston-barrett commented Oct 3, 2016

Mic92 commented Oct 6, 2016 •

edited

[WIP] Add: dunst service #11167

[WIP] Add: dunst service #11167

Conversation

matthiasbeyer commented Nov 20, 2015

matthiasbeyer commented Nov 20, 2015

joachifm Nov 20, 2015

Choose a reason for hiding this comment

matthiasbeyer Nov 20, 2015

Choose a reason for hiding this comment

bendlas commented Dec 7, 2015

matthiasbeyer commented Dec 7, 2015

bendlas commented Dec 7, 2015

bendlas commented Dec 7, 2015

zimbatm commented Apr 9, 2016

matthiasbeyer commented Apr 9, 2016

matthiasbeyer commented Apr 17, 2016

matthiasbeyer commented Jun 23, 2016

matthiasbeyer commented Jun 23, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm commented Jun 24, 2016

matthiasbeyer commented Jun 24, 2016

zimbatm Jun 26, 2016

Choose a reason for hiding this comment

matthiasbeyer Jun 26, 2016

Choose a reason for hiding this comment

joachifm commented Jul 26, 2016

matthiasbeyer commented Jul 26, 2016

joachifm commented Jul 26, 2016

langston-barrett commented Oct 3, 2016

langston-barrett Oct 3, 2016

Choose a reason for hiding this comment

joachifm commented Oct 3, 2016

joachifm commented Oct 3, 2016

langston-barrett commented Oct 3, 2016

Mic92 commented Oct 6, 2016 • edited

Mic92 commented Oct 6, 2016 •

edited