Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.aioinflux: init at 0.9.0 #111849

Merged
merged 2 commits into from Feb 5, 2021

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Add the aioinflux Python package, an asyncio client for InfluxDB. This is an updated version of #70840. @liamdiprose I have included you as a maintainer, as in your original PR. Let me know if you would rather not be a maintainer for this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Feb 4, 2021

Result of nixpkgs-review pr 111849 run on x86_64-linux 1

2 packages built:
  • python37Packages.aioinflux
  • python38Packages.aioinflux

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • package build (see dnscontrol: 3.5.0 -> 3.6.0 #111875 (comment))
  • all depending packages build
  • library tested on x86_64
...ew/pr-111849/results/python38Packages.aioinflux/lib/python3.8/site-packages]$ python
Python 3.8.7 (default, Dec 21 2020, 17:18:55) 
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from aioinflux import InfluxDBClient
>>> client = InfluxDBClient(host='192.168.1.123', db='nixos', mode='blocking')
>>> client.ping()
{'Content-Type': 'application/json', 'Request-Id': '8df43c61-66d2-11eb-8001-2aee9ed82338', 'X-Influxdb-Build': 'OSS', 'X-Influxdb-Version': '1.8.4', 'X-Request-Id': '8df43c61-66d2-11eb-8001-2aee9ed82338', 'Date': 'Thu, 04 Feb 2021 10:20:07 GMT'}
[...]

Looks good to me.

@fabaff
Copy link
Member

fabaff commented Feb 4, 2021

2 packages built:

Hmm, the package for Python 3.9 is missing.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111849 run on x86_64-darwin 1

2 packages built:
  • python37Packages.aioinflux
  • python38Packages.aioinflux

@SuperSandro2000
Copy link
Member

2 packages built:

Hmm, the package for Python 3.9 is missing.

error: boto-2.49.0 not supported for interpreter python3.9

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111849 run on x86_64-linux 1

2 packages built:
  • python37Packages.aioinflux
  • python38Packages.aioinflux

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111849 run on x86_64-linux 1

2 packages built:
  • python37Packages.aioinflux
  • python38Packages.aioinflux

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111849 run on x86_64-darwin 1

2 packages built:
  • python37Packages.aioinflux
  • python38Packages.aioinflux

@SuperSandro2000 SuperSandro2000 merged commit 39d6d4e into NixOS:master Feb 5, 2021
@lopsided98 lopsided98 deleted the aioinflux-init branch February 15, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants