html2text: 1.3.2a -> 2.0.0

[ajs124]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[fabaff]

Result of nixpkgs-review pr 112094 run on x86_64-linux 1

2 packages built:

• bookworm
• html2text

[fabaff]

• package build (see html2text: 1.3.2a -> 2.0.0 #112094 (comment))
• all depending packages build
• library tested on x86_64

...ew/pr-112094]$ ./results/html2text/bin/html2text -version
This is html2text, version 2.0.0
[...]
...ew/pr-112094]$ ./results/html2text/bin/html2text convert.html 
****** My First Heading ******
My first paragraph.
...ew/pr-112094]$ ./results/html2text/bin/html2text test.html 
Segmentation fault (core dumped)

Looks good to me.

The segmentation fault is caused by the limitations of the tool. Like if you try to convert an actual website instead of content from an e-mail client.

[eikek]

lgtm, thank you

[SuperSandro2000]

fails on darwin:

builder for '/nix/store/844ar9pw665hxvsrlyswr8dl5l39kaav-html2text-2.0.0.drv' failed with exit code 1; last 9 log lines:
  unpacking sources
  unpacking source archive /nix/store/gah5gc2bdx8qjl8prpxar2ld0fhk8mdq-source
  source root is source
  patching sources
  configuring
  configure flags: --prefix=/nix/store/9adj6vf0i60365cqbqk8gag43fwkl770-html2text-2.0.0
  Checking C++ compiler... use "clang++"
  Checking for socket libraries... no extra libraries required
  Checking for iconv libraries... Error: Could not determine the library for the iconv API.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112094 run on x86_64-linux 1

2 packages built:

• bookworm
• html2text

[ajs124]

* [x]  package build (see [#112094 (comment)](https://github.com/NixOS/nixpkgs/pull/112094#issuecomment-774417586))

* [ ]  all depending packages build

* [x]  library tested on x86_64

...ew/pr-112094]$ ./results/html2text/bin/html2text -version
This is html2text, version 2.0.0
[...]
...ew/pr-112094]$ ./results/html2text/bin/html2text convert.html 
****** My First Heading ******
My first paragraph.
...ew/pr-112094]$ ./results/html2text/bin/html2text test.html 
Segmentation fault (core dumped)

Looks good to me.

The segmentation fault is caused by the limitations of the tool. Like if you try to convert an actual website instead of content from an e-mail client.

Does the segmentation fault also happen on the version currently in nixpkgs, for the same input?

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112094 run on x86_64-darwin 1

1 package failed to build and are new build failure:

• html2text: log https://termbin.com/06xt

[ajs124]

I decided to deploy an alternative solution, so I'm going to close this.