Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anydesk: Add auto-update support #112179

Merged
merged 1 commit into from Mar 7, 2021
Merged

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Feb 6, 2021

This allows auto-update of the package and reduce maintenance burden.

Refs: #80979

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This allow auto-update of the package and reduce maintenance burden.

Refs: NixOS#80979
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio otavio removed the request for review from Profpatsch February 7, 2021 20:37
@ajs124
Copy link
Member

ajs124 commented Feb 9, 2021

I know I'm repeating myself, but "why"? The r-ryantm can already autoupdate this, without this script.

@otavio
Copy link
Contributor Author

otavio commented Feb 9, 2021

I don't think it can @ajs124.

With this in place, I can run:

nix-shell maintainers/scripts/update.nix --argstr package anydesk

@shyim
Copy link
Member

shyim commented Feb 9, 2021

It can update it. We had already few prs from it

@otavio
Copy link
Contributor Author

otavio commented Feb 9, 2021

If it can, we ought to add it to the default upgrade.nix script so people can use it as a single point to upgrade their packages.

@otavio
Copy link
Contributor Author

otavio commented Feb 11, 2021

So, how I can upgrade it using upgrade.nix script?

@otavio
Copy link
Contributor Author

otavio commented Feb 20, 2021

So, how I can upgrade it using upgrade.nix script?

ping?

@jonringer
Copy link
Contributor

@otavio its default behavior is to check repology.com and check to see if there's a version difference, and attempt to build by substituting the new version. https://repology.org/project/anydesk/versions

So currently it has to wait for another repo to update it, then we will follow suit.

cc @ryantm if I'm wrong

I think having a script which is more closely reflects the "source of truth" is beneficial though

@Mic92 Mic92 merged commit 10a3345 into NixOS:master Mar 7, 2021
@otavio otavio deleted the auto-upgrade/anydesk branch April 28, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants