Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode and vscode ms-python.python extension #112183

Closed
wants to merge 3 commits into from

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Feb 6, 2021

I tried upgrading the vscode ms-python.python extension in my local nixpkgs branch, and quickly got in over my head.

  1. ms-python.python now requires ms-toolsai.jupyter
  2. I'm not sure how propagatedBuildInputs works with vscode extensions. Simply adding propagatedBuildInputs didn't work.
  3. ms-toolsai.jupyter seems to only work on vscode 1.52.1 with the cmdline argument --enable-proposed-api jupyter, but this is not required if you upgrade to vscode to 1.53.0.

Probably @jraygauthier @eadwu @Synthetica9 have much better ways to solve this, so I'm just going to open and then close this PR to keep a record of those steps, but I assume someone will come up with a better series of steps for actually merging into nixpkgs.

@eadwu
Copy link
Member

eadwu commented Feb 6, 2021

ms-python.python does not require ms-toolsai.jupyter if I remember correctly, jupyter support was just extracted to a standalone extension.

I'm not sure where --enable-proposed-api jupyter comes from but [Python] jupyter support has been fine with the extension versions I use locally (unless using the insiders vscode is making a difference).

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Feb 6, 2021

Re the Jupyter requirement

This is what I was referring to: image
Source: https://github.com/microsoft/vscode-python/releases/tag/2020.11.358366026

@jraygauthier
Copy link
Member

Ok, so I assume this is fine now that this has been merged?

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Feb 7, 2021

Ok, so I assume this is fine now that this has been merged?

I don't quite follow.

@jraygauthier
Copy link
Member

I don't quite follow.

I ok, I assume without checking this has been merged as was closed,without comment nor waiting on input from mentioned people.

I can see now that it indeed wasn't merged.

Why not leave this open and wait a bit?

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Feb 7, 2021

I just wanted to put it on your radar, but not merge it because I realized that I didn't know what I was doing w.r.t. packaging vscode. I'm happy to re-open if you prefer.

@jraygauthier
Copy link
Member

Alright, as you see fit. We'll probably end up with the same issue when we attempt to update code + ms-python.
Seems like a good first draft and indeed raises the issue. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants