Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ox: init at 0.2.7 #112263

Merged
merged 1 commit into from Feb 7, 2021
Merged

ox: init at 0.2.7 #112263

merged 1 commit into from Feb 7, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented Feb 7, 2021

Ox is an independent Rust text editor that runs in your terminal

Motivation for this change

Add ox editor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Feb 7, 2021

Result of nixpkgs-review pr 112263 run on x86_64-linux 1

1 package built:
  • ox

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.maintainers is set
  • package build (see ox: init at 0.2.7 #112263 (comment))
  • all depending packages build
  • tested on x86_64
...ew/pr-112263]$ ./results/ox/bin/ox -h
Ox 0.2.7
Author: Luke <https://github.com/curlpipe>
An independent Rust powered text editor

Looks good to me. The naming could lead to a discussion as it could conflict with Ox, programming language. Ox is not Open Source, thus is only a minor issue.

Looks good to me.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112263 run on x86_64-darwin 1

1 package built:
  • ox

@SuperSandro2000 SuperSandro2000 merged commit 603c324 into NixOS:master Feb 7, 2021
@moni-dz moni-dz deleted the add-ox branch February 7, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants