Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z3: 4.8.9 -> 4.8.10 #112551

Merged
merged 1 commit into from Feb 10, 2021
Merged

z3: 4.8.9 -> 4.8.10 #112551

merged 1 commit into from Feb 10, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 9, 2021

Motivation for this change

Update to latest upstream release 4.8.10

Change log: https://github.com/Z3Prover/z3/releases/tag/z3-4.8.10

Also, ran nixpkgs-fmt but nixpkgs-review takes hours.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Feb 9, 2021
View reviewed changes
pkgs/applications/science/logic/z3/default.nix
Comment on lines +10 to +12
, ocaml ? null
, findlib ? null
, zarith ? null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, ocaml ? null
, findlib ? null
, zarith ? null
, ocaml
, findlib
, zarith

@ttuegel ttuegel merged commit 17c6edb into NixOS:master Feb 10, 2021
@ttuegel
Copy link
Member

ttuegel commented Feb 10, 2021

Thanks!

@fabaff fabaff mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ttuegel ttuegel ttuegel approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @ttuegel @SuperSandro2000