Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] virtualbox: 6.1.16 -> 6.1.18 #112744

Merged
merged 2 commits into from Feb 13, 2021
Merged

[20.09] virtualbox: 6.1.16 -> 6.1.18 #112744

merged 2 commits into from Feb 13, 2021

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Feb 11, 2021

Signed-off-by: Bryan A. S bryanasdev000@gmail.com
(cherry picked from commit 72e688c)

Motivation for this change

Backport #110550 in 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000 @jfroche
virtualbox: 6.1.16 -> 6.1.18
14010ae 
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
(cherry picked from commit 72e688c)
@jfroche jfroche changed the title virtualbox: 6.1.16 -> 6.1.18 [20.09] virtualbox: 6.1.16 -> 6.1.18 Feb 11, 2021
@blitz blitz mentioned this pull request Feb 11, 2021
Closed
10 tasks
@blitz
Copy link
Contributor

blitz commented Feb 11, 2021

@jfroche Can you also cherry pick 5e56f17 to unbreak VirtualBox on Linux 5.10. I've tested that this works (compiled and running VBox on 5.10 right now).

@blitz blitz requested a review from tfc February 11, 2021 12:12
@jfroche
Copy link
Contributor Author

jfroche commented Feb 11, 2021

@jfroche Can you also cherry pick 5e56f17 to unbreak VirtualBox on Linux 5.10. I've tested that this works (compiled and running VBox on 5.10 right now).

Cherry picked your commit but I am wondering now if we should instead revert 4e5e460 ?

@blitz
Copy link
Contributor

blitz commented Feb 11, 2021

@jfroche Can you also cherry pick 5e56f17 to unbreak VirtualBox on Linux 5.10. I've tested that this works (compiled and running VBox on 5.10 right now).

Cherry picked your commit but I am wondering now if we should instead revert 4e5e460 ?

I've seen it. It also marks other packages as broken. I only wanted to unbreak the VBox changes.

blitz
blitz approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@blitz blitz requested a review from flokli February 12, 2021 23:37
@tfc
Copy link
Contributor

tfc commented Feb 13, 2021

@flokli @blitz @jfroche i'm running this now, works great!

@flokli flokli merged commit ef56235 into NixOS:release-20.09 Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@blitz blitz blitz approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jfroche @blitz @tfc @flokli @bryanasdev000