Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard-octant-plugin: 0.9.0 -> 0.9.1 #112924

Merged
merged 1 commit into from Feb 12, 2021

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Feb 12, 2021

Motivation for this change

Bump starboard-octant-plugin to 0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 112924 run on x86_64-linux 1

1 package built:
  • starboard-octant-plugin

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112924 at 5fc6a48 run on aarch64-linux 1

1 package built:
1 suggestion:
  • error: no-flags-array

    buildFlagsArray is only intended to be used in Bash, not as a Nix attribute.

    Near pkgs/applications/networking/cluster/octant/plugins/starboard-octant-plugin.nix:16:3:

       |
    16 |   buildFlagsArray = [ "-ldflags=" "-s" "-w" ];
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit 091f73f into NixOS:master Feb 12, 2021
@06kellyjac 06kellyjac deleted the starboard-octant-plugin branch February 12, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants