Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xh: 0.5.0 -> 0.7.0, rename from ht-rust #112952

Merged
merged 1 commit into from Feb 13, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112952 at ad93c482 run on x86_64-linux 1

1 package built:
1 suggestion:
  • error: no-flags-array

    checkFlagsArray is only intended to be used in Bash, not as a Nix attribute.

    Near pkgs/tools/networking/xh/default.nix:18:3:

       |
    18 |   checkFlagsArray = [ "--skip=basic_options" ];
       |   ^
    

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112952 at ad93c482 run on aarch64-linux 1

1 package built:
1 suggestion:
  • error: no-flags-array

    checkFlagsArray is only intended to be used in Bash, not as a Nix attribute.

    Near pkgs/tools/networking/xh/default.nix:18:3:

       |
    18 |   checkFlagsArray = [ "--skip=basic_options" ];
       |   ^
    

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112952 run on x86_64-darwin 1

1 package built:
  • xh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants