macbook15-spi-driver: init at 0.1 #113214
Conversation
| { lib, stdenv, kernel, fetchFromGitHub, }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "macbook15-spi-driver"; |
There was a problem hiding this comment.
| name = "macbook15-spi-driver"; | |
| pname = "macbook15-spi-driver"; |
| license = lib.licenses.gpl2Only; | ||
| platforms = platforms.linux; | ||
| maintainers = [ lib.maintainers.hlolli ]; |
There was a problem hiding this comment.
| license = lib.licenses.gpl2Only; | |
| platforms = platforms.linux; | |
| maintainers = [ lib.maintainers.hlolli ]; | |
| license = licenses.gpl2Only; | |
| platforms = platforms.linux; | |
| maintainers = [ maintainers.hlolli ]; |
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "macbook15-spi-driver"; | ||
| version = "0.1"; |
| }; | ||
|
|
||
| buildPhase = '' | ||
| make -C ${kernel.dev}/lib/modules/${kernel.modDirVersion}/build \ |
There was a problem hiding this comment.
You can do makeFlags = [ "KDIR=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build" ]; here: https://github.com/hlolli/macbook15-spi-driver/blob/86a2f37ca0d2a4729a32b636dc48f39c522dd8ad/Makefile#L9
also see nixpkgs/pkgs/os-specific/linux/exfat/default.nix
|
This has now a merge conflict. |
|
Are you still working on this? |
|
This has left my radar for now. Sadly linux isn't allowed where I'm working now. This kernel module was as far as I remember crucial to get things to work at the time I tested it. Feel free to take this PR over the finishing line, if I know myself, then I'll not be using this computer for another 3 months. |
|
I cannot really test this. Kernel driver require regular maintenance as kernel upgrades will break them. Let's close this until we have a real user/maintainer. |
Motivation for this change
This kernel-module is part of macbook pro 15+ hardware support NixOS/nixos-hardware#231
Things done
This module is fork of a fork https://github.com/roadrunner2/macbook12-spi-driver which includes a branch "mbp15" which as far as I know is the only way to get the touchbar working on macbooks 2018 and later (without which there aren't any F-keys available). The reason I forked it, is because I failed to be able to get the ambient light sensor nor keyboard backlight working, without using code from the contents from the "touchbar" branch (the main branch). So I merged together the changes on both branches to get all working. I'll make sure to maintain this module as changes come upstream.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)