Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/services/kmscon: fix systemd configuration #113237

Merged
merged 1 commit into from Feb 21, 2021

Conversation

jflanglois
Copy link
Contributor

@jflanglois jflanglois commented Feb 15, 2021

Motivation for this change

This fixes #112616. The solution here follows the approach documented in the Arch Linux wiki.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh
Copy link
Contributor

xaverdh commented Feb 17, 2021

This will make kmscon run on every new tty right? Could we also add an option to the module so it only runs on certain ttys?

@jflanglois
Copy link
Contributor Author

jflanglois commented Feb 17, 2021

This will make kmscon run on every new tty right? Could we also add an option to the module so it only runs on certain ttys?

That is correct, but that is also the intent of the existing code (unless I misunderstand). I would suggest we expand that in a follow up PR since this one is just meant to fix the broken module.

@symphorien
Copy link
Member

I reproduced the issue on a nixos-rebuild build-vm vm without the PR and checked it is fixed with it.

@symphorien symphorien merged commit 1d55adb into NixOS:master Feb 21, 2021
@jflanglois jflanglois deleted the fix-kmscon branch February 21, 2021 14:40
@jflanglois
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/kmscon: services.kmscon.enable does not affect
3 participants