authy: init at 1.8.3

[iAmMrinal0]

Motivation for this change

Package Authy. Closes #112697

This is my first init package. I'd like some feedback on how things can be simplified. Adding a few things that I personally had difficulty with and/or learnt through the process:

• I started off with having the buildInputs in the let block due to which autoPatchelfHook could not find the required libraries.
• Found out from Nixos Wiki that I needn't patchelf manually and autoPatchelfHook will take care of finding the required libraries based on buildInputs.
• Instead of running the authy binary, we could run the electron app directly. So wrapped the app with electron
• The existing derivation for spotify helped as a reference for snap apps and am glad that it had good comments around it.

I had support from quite a few helpful people over at the NixOS Discord which made this a bit easier as they also debugged it to help out in getting this sorted.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 113307 at 2bc137e run on x86_64-linux 1

1 package built:

• authy

2 suggestions:

• warning: unused-argument

  Unused argument: glibc.
  Near pkgs/applications/misc/authy/default.nix:2:56:

    |
  2 | , dbus, electron_9, expat, fetchurl, gdk-pixbuf, glib, glibc, gtk3, lib
    |                                                        ^
  

• warning: unused-argument

  Unused argument: libpulseaudio.
  Near pkgs/applications/misc/authy/default.nix:3:43:

    |
  3 | , libappindicator-gtk3, libdbusmenu-gtk3, libpulseaudio
    |                                           ^
  

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113307 run on x86_64-linux 1

1 package built:

• authy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

authy:

gcc-unwrapped is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/misc/authy/default.nix:51:10:

   |
51 |   inherit buildInputs pname version;
   |          ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md