Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Fix DRM_AMD_DC_DCN for >=5.11 #113601

Closed
wants to merge 1 commit into from
Closed

linux: Fix DRM_AMD_DC_DCN for >=5.11 #113601

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Feb 18, 2021 •
edited

Motivation for this change

The DCN3 variant was removed in torvalds/linux@20f2ffe

Edit: Its functionality was merged into DRM_AMD_DC_DCN which defaults on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb changed the title linux: Fix DRM_AMD_DC_DCN for >5.11 linux: Fix DRM_AMD_DC_DCN for >=5.11 Feb 18, 2021
kira-bruneau
kira-bruneau approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 😄

srhb
srhb commented Feb 18, 2021
View reviewed changes
Copy link
Contributor Author

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MetaDark You were right, we do not need the DCN option explicitly, it defaults to on in 5.11. :)

@srhb
linux: Drop DRM_AMD_DC_DCN3_0 for >=5.11
4ae87dc 
Its functionality has been merged into DRM_AMD_DC_DCN which is on by
default.
@B4dM4n
Copy link
Contributor

B4dM4n commented Feb 18, 2021

This fix and more AMD related settings are already in staging: #109105

@srhb
Copy link
Contributor Author

srhb commented Feb 18, 2021

@B4dM4n So it is! Thanks.

@srhb srhb closed this Feb 18, 2021
@srhb srhb deleted the drop_dcn3 branch February 18, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau kira-bruneau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @B4dM4n @kira-bruneau