Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah: 1.19.4 -> 1.19.6 #113653

Merged
merged 1 commit into from Feb 19, 2021
Merged

buildah: 1.19.4 -> 1.19.6 #113653

merged 1 commit into from Feb 19, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 18, 2021

https://github.com/containers/buildah/releases/tag/v1.19.6

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 18, 2021

Result of nixpkgs-review pr 113653 at 28f5b52 run on aarch64-linux 1

2 packages built:
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/buildah/default.nix:29:5:

       |
    29 |     ../../../applications/virtualization/podman/remove-unconfigured-runtime-warn.patch
       |     ^
    

Result of nixpkgs-review pr 113653 at 28f5b52 run on x86_64-linux 1

2 packages built:
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/tools/buildah/default.nix:29:5:

       |
    29 |     ../../../applications/virtualization/podman/remove-unconfigured-runtime-warn.patch
       |     ^
    

@adisbladis adisbladis merged commit ead9e55 into NixOS:master Feb 19, 2021
@zowoq zowoq deleted the buildah branch February 19, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants