Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

garble: fix aarch64-linux and pin go to 1.15 #113744

Merged
merged 2 commits into from Feb 20, 2021
Merged

garble: fix aarch64-linux and pin go to 1.15 #113744

merged 2 commits into from Feb 20, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 20, 2021

Motivation for this change

Fixing both x86-64-linux and aarch64-linux builds, darwin was always broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and DavHau February 20, 2021 01:56
@zowoq
Copy link
Contributor

zowoq commented Feb 20, 2021

Thanks!

@zowoq zowoq merged commit c62662c into NixOS:master Feb 20, 2021
@bobrik bobrik deleted the ivan/garble-fixes branch March 6, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@DavHau DavHau Awaiting requested review from DavHau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobrik @zowoq