Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomuks: 0.2.2 -> 0.2.3 #113760

Merged
merged 3 commits into from Feb 22, 2021
Merged

gomuks: 0.2.2 -> 0.2.3 #113760

merged 3 commits into from Feb 22, 2021

Conversation

chvp
Copy link
Member

@chvp chvp commented Feb 20, 2021

Motivation for this change

Package bump

Things done

Ran the program and sent some messages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 20, 2021

Result of nixpkgs-review pr 113760 at 830a5fc run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/networking/instant-messengers/gomuks/default.nix:57:5:

       |
    57 |     license = licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 113760 at 830a5fc run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/networking/instant-messengers/gomuks/default.nix:57:5:

       |
    57 |     license = licenses.gpl3;
       |     ^
    

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113760 run on x86_64-darwin 1

1 package built:
  • gomuks

@SuperSandro2000 SuperSandro2000 merged commit 4249bb4 into NixOS:master Feb 22, 2021
@chvp chvp deleted the bump-gomuks branch February 22, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants