Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python spyder: 2.3.7 -> 2.3.8 #11389

Closed
wants to merge 1 commit into from
Closed

python spyder: 2.3.7 -> 2.3.8 #11389

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 1, 2015

Note that this update doesn't fix the failing Python 3 builds.

cc @bjornfor @domenkozar

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @domenkozar and @bjornfor to be potential reviewers

@bjornfor
Copy link
Contributor

bjornfor commented Dec 1, 2015

Pushed to master (4ff3787). Thanks.

@bjornfor bjornfor closed this Dec 1, 2015
@FRidh FRidh deleted the spyder branch December 1, 2015 19:31
@domenkozar
Copy link
Member

python3Packages.spyder is not working due to python2.7 dependencies propagated into environment, I have yet to figure out what's going on.

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2015

@domenkozar http://hydra.nixos.org/build/28408310/nixlog/2/raw

unpacking sources
unpacking source archive /nix/store/xfa7ii0fflb2cbqz0cdj65c22j783c6w-spyder-2.3.8.zip
source root is spyder-2.3.8
patching sources
configuring
building
WARNING: unable to build documentation because Sphinx is not installed
usage: nix_run_setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: nix_run_setup.py --help [cmd1 cmd2 ...]
   or: nix_run_setup.py --help-commands
   or: nix_run_setup.py cmd --help

error: invalid command 'bdist_wheel'
builder for ‘/nix/store/shw2ishdn56klvxlab6xq62gz2azwgfm-spyder-2.3.8.drv’ failed with exit code 1

If I am correct it fails because wheels are not supported by Spyder (will come with 3.0).
I guess we're just lucky it does work with 2.7.

Request for wheels support: spyder-ide/spyder#2574
Merged: spyder-ide/spyder#2774

@domenkozar
Copy link
Member

We have the setuptools shim to inject setuptools before distutils. Our problem is different (python2.7 dependencies on python3 project):

$ nix-shell -A python3Packages.spyder --command "echo \$PYTHONPATH" -I /home/ielectric/dev                                                                                
/nix/store/hjf8sarhrlvdjz942gs85q4vcg0dghr3-pyside-1.2.2/lib/python2.7/site-packages:/nix/store/hjf8sarhrlvdjz942gs85q4vcg0dghr3-pyside-1.2.2/lib/python2.7/site-packages:/nix/store/91jyivagg6yga9nd2znsvxd66806fbk4-pylint-1.4.1/lib/python2.7/site-packages:/nix/store/91jyivagg6yga9nd2znsvxd66806fbk4-pylint-1.4.1/lib/python2.7/site-packages:/nix/store/lwyc3qn72mm5lddbf4bl5h8hra17dz9m-python2.7-astroid-1.3.4/lib/python2.7/site-packages:/nix/store/lwyc3qn72mm5lddbf4bl5h8hra17dz9m-python2.7-astroid-1.3.4/lib/python2.7/site-packages:/nix/store/56s3fp1fh3099x067pnk37cljjcjls85-python2.7-logilab-common-0.63.2/lib/python2.7/site-packages:/nix/store/56s3fp1fh3099x067pnk37cljjcjls85-python2.7-logilab-common-0.63.2/lib/python2.7/site-packages:/nix/store/wh4wi0cl6m208h7ml8h5pv68vzqlhdj5-python2.7-unittest2-1.1.0/lib/python2.7/site-packages:/nix/store/wh4wi0cl6m208h7ml8h5pv68vzqlhdj5-python2.7-unittest2-1.1.0/lib/python2.7/site-packages:/nix/store/jhpm56qljlcwsdyhr54ncafkxh48zmgc-python2.7-six-1.9.0/lib/python2.7/site-packages:/nix/store/jhpm56qljlcwsdyhr54ncafkxh48zmgc-python2.7-six-1.9.0/lib/python2.7/site-packages:/nix/store/q04znh7k9pcagcxqmlxz0qqsdfki0scw-python-recursive-pth-loader-1.0/lib/python2.7/site-packages:/nix/store/q04znh7k9pcagcxqmlxz0qqsdfki0scw-python-recursive-pth-loader-1.0/lib/python2.7/site-packages:/nix/store/v9pq6f0s1r5fdybqc7pbv7mkb33lx9yy-python-2.7.10/lib/python2.7/site-packages:/nix/store/v9pq6f0s1r5fdybqc7pbv7mkb33lx9yy-python-2.7.10/lib/python2.7/site-packages:/nix/store/x3gfdavv38ghprna3z47grarwblgwb7f-python2.7-setuptools-18.2/lib/python2.7/site-packages:/nix/store/x3gfdavv38ghprna3z47grarwblgwb7f-python2.7-setuptools-18.2/lib/python2.7/site-packages:/nix/store/2wxmwq26ya78ydg2mxbsg53mqrvc1p9j-python2.7-argparse-1.4.0/lib/python2.7/site-packages:/nix/store/2wxmwq26ya78ydg2mxbsg53mqrvc1p9j-python2.7-argparse-1.4.0/lib/python2.7/site-packages:/nix/store/nd0zccd29gh36f909y9cd4i786qdixji-python2.7-traceback2-1.4.0/lib/python2.7/site-packages:/nix/store/nd0zccd29gh36f909y9cd4i786qdixji-python2.7-traceback2-1.4.0/lib/python2.7/site-packages:/nix/store/rg3f9fxw4nc1p5fjf6a1zzsvd5chpraq-python2.7-pbr-1.8.1/lib/python2.7/site-packages:/nix/store/rg3f9fxw4nc1p5fjf6a1zzsvd5chpraq-python2.7-pbr-1.8.1/lib/python2.7/site-packages:/nix/store/rpii6kg1i63j8p7np94p6fkdqwwwhg87-python2.7-linecache2-1.0.0/lib/python2.7/site-packages:/nix/store/rpii6kg1i63j8p7np94p6fkdqwwwhg87-python2.7-linecache2-1.0.0/lib/python2.7/site-packages

@domenkozar
Copy link
Member

Found the issue, it's pylint propagated build input that propagated python2.7. Need to figure out how to solve this one properly.

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2015

Simply put a callPackage pylint in python-packages.nix? That's what I did with spyder.

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2015

That way it becomes available for all Python versions, which is what we want anyhow.

@domenkozar
Copy link
Member

Exactly :) I just wonder how we can prevent a similar issue in future.
Probably hard to do without some linting.

On Wed, 2 Dec 2015, 16:56 Frederik Rietdijk notifications@github.com
wrote:

That way it becomes available for all Python versions, which is what we
want anyhow.


Reply to this email directly or view it on GitHub
#11389 (comment).

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2015

Something in buildPythonPackage that asserts that (propagated) build inputs
(no need to go deeper) have the same ${python.pythonVersion} as
${python.pythonVersion}, with the latter being the python argument to the
current buildPythonPackage call.

On Wed, Dec 2, 2015 at 4:58 PM, Domen Kožar notifications@github.com
wrote:

Exactly :) I just wonder how we can prevent a similar issue in future.
Probably hard to do without some linting.

On Wed, 2 Dec 2015, 16:56 Frederik Rietdijk notifications@github.com
wrote:

That way it becomes available for all Python versions, which is what we
want anyhow.


Reply to this email directly or view it on GitHub
#11389 (comment).


Reply to this email directly or view it on GitHub
#11389 (comment).

@domenkozar
Copy link
Member

fixed in 6cf4e29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants